Change constant time and cache resistant ECC mulmod #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
ecc_cr_fix
branch
2 times, most recently
from
063b316
to
95df2ca
Compare
toddouska
reviewed
Apr 9, 2020
| @@ -89,6 +89,30 @@ mp_digit get_digit(mp_int* a, int n) | |||
| return (n >= a->used || n < 0) ? 0 : a->dp[n]; | |||
| } | |||
|
|
|||
| int mp_cond_copy(mp_int* a, int copy, mp_int* b) | |||
There was a problem hiding this comment.
Looks good but please add a basic comment here describing why and what this does for ease of future maintenance.
Ensure points being operated on change to make constant time.
|
This pull request seem to have been associated with CVE-2020-11713. |
|
Yes, this pull request is based on the report. |
toddouska
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure points being operated on change to make constant time.