Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process multiple OCSP responses #3389

Merged
merged 4 commits into from Oct 20, 2020
Merged

Process multiple OCSP responses #3389

merged 4 commits into from Oct 20, 2020

Conversation

tmael
Copy link
Contributor

@tmael tmael commented Oct 14, 2020 •
edited by dgarske

ZD#10987.

support for OCSP request/response for multiple certificates

Test case: wolfSSL/wolfssl-examples#231

@tmael tmael requested a review from dgarske October 14, 2020 14:13
dgarske
dgarske requested changes Oct 14, 2020
View reviewed changes
wolfcrypt/src/asn.c Outdated Show resolved Hide resolved
@dgarske dgarske assigned tmael and unassigned dgarske Oct 14, 2020
@tmael
Copy link
Contributor Author

tmael commented Oct 15, 2020

Thanks, @dgarske, Nice work!
No issues with the following test configurations.

  • client and server are able to connect with an OCSP responder with the id-pkix-ocsp-nocheck cert extensions.
    • server makes OCSP request and processes the OCSP response from the responder.
    • client skips performing OCSP request/response with the OCSP responder.
  • Verified OcspResponseDecode() can now process multiple SingleResponses OCSP responses and stores it in a CertStatus link list.

dgarske
dgarske approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todd should do a final on this. Both Tesfa and I worked on the PR.

@tmael tmael assigned toddouska and unassigned tmael Oct 15, 2020
@toddouska toddouska merged commit a1afc6c into wolfSSL:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddouska toddouska toddouska approved these changes

@dgarske dgarske dgarske approved these changes

Assignees

@toddouska toddouska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmael @toddouska @dgarske