Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtls 1.3: allow to skip cookie exchange on resumption #6929

Merged

Conversation

julek-wolfssl
Copy link
Member

@julek-wolfssl julek-wolfssl commented Oct 31, 2023

dtls 1.3: allow to skip cookie exchange on resumption
tls 1.3: do cookie exchange when asked too even when found a matching cipher

tls 1.3: do cookie exchange when asked too even when found a matching cipher
Copy link
Contributor

@rizlik rizlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work.
Do you think we should add a test in which the client sends early data after a cookie exchange? Is this allowed by the RFC?

examples/client/client.c Outdated Show resolved Hide resolved
src/dtls13.c Outdated Show resolved Hide resolved
src/tls13.c Show resolved Hide resolved
@julek-wolfssl
Copy link
Member Author

Do you think we should add a test in which the client sends early data after a cookie exchange? Is this allowed by the RFC?

This is allowed but I think this defeats the purpose of 0-RTT. Also, this is not supported in wolfSSL currently. Do you want me to add some I/O manipulation to delay sending the early data?

@julek-wolfssl
Copy link
Member Author

Retest this please

@rizlik
Copy link
Contributor

rizlik commented Nov 6, 2023

Do you think we should add a test in which the client sends early data after a cookie exchange? Is this allowed by the RFC?

This is allowed but I think this defeats the purpose of 0-RTT. Also, this is not supported in wolfSSL currently. Do you want me to add some I/O manipulation to delay sending the early data?

No, I think it's OK like this for now.

@JacobBarthelmeh JacobBarthelmeh merged commit c5e2f41 into wolfSSL:master Nov 6, 2023
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants