Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlayStation compatibility #7072

Merged
merged 1 commit into from
Feb 28, 2024
Merged

PlayStation compatibility #7072

merged 1 commit into from
Feb 28, 2024

Conversation

farazrbx
Copy link
Contributor

Description

Changes required for building wolfSSL on PlayStation 4 and 5.

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Dec 15, 2023

Hi @farazrbx ,

Thank you for this PR. In order to accept any code contributions we require a signed contributor agreement. Would you mind emailing support@wolfssl.com and referencing this PR? It would also be helpful to include your location and understand more about your project.

Thanks,
David Garske, wolfSSL

dgarske
dgarske requested changes Dec 15, 2023
View reviewed changes
wolfssl/openssl/crypto.h Show resolved Hide resolved
src/wolfio.c Outdated Show resolved Hide resolved
src/ssl_asn1.c Outdated Show resolved Hide resolved
@dgarske dgarske self-assigned this Dec 15, 2023
@dgarske
Copy link
Contributor

dgarske commented Dec 26, 2023

Okay to test

dgarske
dgarske requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR. Please respond about getting the signed contributor agreement.

wolfssl/wolfcrypt/types.h Outdated Show resolved Hide resolved
wolfssl/openssl/crypto.h Show resolved Hide resolved
dgarske
dgarske previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but still waiting for contribution agreement from @farazrbx

@dgarske
Copy link
Contributor

dgarske commented Jan 12, 2024

Retest this please

@dgarske
Copy link
Contributor

dgarske commented Jan 19, 2024

okay to test

dgarske
dgarske requested changes Jan 19, 2024
View reviewed changes
wolfssl/wolfcrypt/types.h Outdated Show resolved Hide resolved
dgarske
dgarske previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @farazrbx . Excellent work. Once we have the contribution agreement in place I'll merge.

@dgarske
Copy link
Contributor

dgarske commented Jan 19, 2024

okay to test

@dgarske
Copy link
Contributor

dgarske commented Feb 27, 2024

FYI: @farazrbx looks like there is a merge conflict with wolfssl/wolfcrypt/wc_port.h.

@farazrbx
Copy link
Contributor Author

farazrbx commented Feb 27, 2024 •
edited
Loading

FYI: @farazrbx looks like there is a merge conflict with wolfssl/wolfcrypt/wc_port.h.

Rebased my PR from master. It should be good to go now.

@farazrbx farazrbx closed this Feb 27, 2024
@farazrbx farazrbx reopened this Feb 27, 2024
@dgarske
Copy link
Contributor

dgarske commented Feb 27, 2024

Okay to test.

@dgarske
Copy link
Contributor

dgarske commented Feb 27, 2024

Contribution approved by Larry.

@dgarske dgarske assigned douzzer and unassigned dgarske Feb 27, 2024
@douzzer douzzer merged commit 6500444 into wolfSSL:master Feb 28, 2024
112 checks passed
@farazrbx farazrbx deleted the rbx branch February 28, 2024 17:15
@dgarske dgarske mentioned this pull request Feb 29, 2024
Merged
dgarske
dgarske reviewed Feb 29, 2024
View reviewed changes
wolfssl/wolfio.h
@@ -163,11 +163,15 @@
#include <sys/socket.h>
#include <arpa/inet.h>
#include <netinet/in.h>
#include <netdb.h>
#ifdef HAVE_NETDB_H
#include <netdb.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This change broke the wolfTPM test, because it (wolfTPM) was not setting HAVE_NETDB_H. Fixed in wolfTPM.

@farazrbx farazrbx mentioned this pull request Mar 1, 2024
Closed
farazrbx
farazrbx commented Mar 29, 2024
View reviewed changes
wolfssl/wolfio.h
#ifdef __PPU
#include <netex/errno.h>
#else
#include <sys/ioctl.h>
#ifdef HAVE_SYS_IOCTL_H
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarske @douzzer
Apparently, this check is removed in the current master.
Could you add it back please in src/wolfio.c:85 ?
I can open a PR, but it might take forever to get legal approval.
Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @farazrbx , I don't recall that getting changed back, but we will take a look. Thanks, David Garske, wolfSSL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wolfSSL/wolfssl/pull/7288/files

@dgarske dgarske mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarske dgarske dgarske approved these changes

@douzzer douzzer douzzer approved these changes

@wolfSSL-Bot wolfSSL-Bot Awaiting requested review from wolfSSL-Bot

@julek-wolfssl julek-wolfssl Awaiting requested review from julek-wolfssl

Assignees

@douzzer douzzer

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@farazrbx @wolfSSL-Bot @dgarske @douzzer @julek-wolfssl