TLS13 padding bounds check #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
step, check that the index doesn't wrap around due to a malformed packet
dgarske
previously approved these changes
Dec 27, 2023
|
retest this please. |
douzzer
requested changes
Jan 2, 2024
src/internal.c
Outdated
Comment on lines
21169
to
21170
| /* check i isn't too big and won't wrap around on --i */ | ||
| if (i > ssl->buffers.inputBuffer.length || i == 0) { |
There was a problem hiding this comment.
If we need to test for integer overflow, then I suspect we need to test ssl->buffers.inputBuffer.idx + ssl->curSize - ssl->specs.aead_mac_size before casting it.
inputBuffer length
douzzer
approved these changes
Jan 4, 2024
kojo1
added a commit
to kojo1/wolfssl
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When removing the padding for the TLS13 verify message step, check that the index doesn't wrap around due to a malformed packet
Fixes #7089
Testing
Tested with malicious client example provided by the bug reporter.
Checklist