EdDsa: check private value after sign #7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
eddsa_check_priv
branch
from
c898051
to
afc7537
Compare
|
retest this please. |
dgarske
requested changes
Feb 12, 2024
Check the private value hasn't changed during signing with EdDSA.
SparkiDev
force-pushed
the
eddsa_check_priv
branch
from
afc7537
to
e28d6a7
Compare
|
retest this please |
|
Added comments at top of ed25519.c and ed448.c. |
dgarske
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check the private value hasn't changed during signing with EdDSA.
Fixes zd#17438
Testing
./configure '--disable-shared' '--enable-curve25519' '--enable-ed25519' '--enable-curve448' '--enable-ed448' 'CFLAGS=-DWOLFSSL_EDDSA_CHECK_PRIV_ON_SIGN'
Checklist