AES RISC-V 64-bit ASM: ECB/CBC/CTR/GCM/CCM #7569
Merged
+9,788
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
@SparkiDev I've got a few RISC-V targets here now, so I will try this on actual HW. |
dgarske
requested changes
May 26, 2024
There was a problem hiding this comment.
./configure --enable-all --enable-riscv-asm
wolfcrypt/src/aes.c: In function '_AesXtsHelper':
wolfcrypt/src/aes.c:12631:16: error: implicit declaration of function '_AesEcbEncrypt'; did you mean 'wc_AesEcbEncrypt'? [-Werror=implicit-function-declaration]
12631 | return _AesEcbEncrypt(aes, out, out, totalSz);
| ^~~~~~~~~~~~~~
| wc_AesEcbEncrypt
wolfcrypt/src/aes.c:12631:16: error: nested extern declaration of '_AesEcbEncrypt' [-Werror=nested-externs]
wolfcrypt/src/aes.c:12634:16: error: implicit declaration of function '_AesEcbDecrypt'; did you mean 'wc_AesEcbDecrypt'? [-Werror=implicit-function-declaration]
12634 | return _AesEcbDecrypt(aes, out, out, totalSz);
| ^~~~~~~~~~~~~~
| wc_AesEcbDecrypt
wolfcrypt/src/aes.c:12634:16: error: nested extern declaration of '_AesEcbDecrypt' [-Werror=nested-externs]
|
HiFive Unleashed at 1.4GHz On master |
@SparkiDev says AES XTS is not yet support with RISC-V ASM. Note: I tried to use |
|
@SparkiDev is this RISC-V ASM PR ready for merge? I can’t tell if you are planning to push anything else to it. |
Add implementations of AES for ECB/CBC/CTR/GCM/CCM for RISC-V using assembly. Assembly with standard/scalar cryptography/vector cryptographt instructions.
|
Fixed --enable-all to work. |
|
retest this please |
|
Updated benchmarks: HiFive Unleashed at 1.4GHz |
dgarske
approved these changes
Jun 6, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
AES RISC-V 64-bit ASM: ECB/CBC/CTR/GCM/CCM
|
@dgarske - question on the benchmarks fix data size vs fixed time: In the vs Then for comparison your ran this for both: The output on The output on Why the difference in fixed data size vs fixed time? Additionally, perhaps just nit-picky, but curious: it appears there was also difference in vs It appears that In any case - that's an astonishing performance boost by @SparkiDev :) |
|
The size of data processed is the number of 1048576 byte (=1MB) buffers encrypted/decrypted. I have no idea why the number of bits in SP changed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add implementations of AES for ECB/CBC/CTR/GCM/CCM for RISC-V using assembly.
Assembly with standard/scalar cryptography/vector cryptographt instructions.
Testing
./configure --enable-all --enable-riscv-asm
Checklist