build system fixes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example, now you can do: make PREFIX=/usr without any modification to the Makefile and have it behave as intended.
In Ubuntu, the attached patch was applied to achieve the following: * as-needed.patch: Fix object/library link order for --as-needed. When building with --as-needed, libraries need to be listed on the link line after the objects that reference them. In the autotools world (and elsewhere), the LDFLAGS variable has been split into LDFLAGS and LDADD to represent the need to list libs last. This patch makes that change to your Makefile, so this builds correctly with --as-needed in LDFLAGS.
There are circumstances where you just want to repeat the build without running the tests. keeping the "test" target distinct from the "all" target makes it possible to do that cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains some build system fixes from debian packaging.