Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MT 20.2 features & bugfixes & french translation #164

Merged
merged 223 commits into from Feb 2, 2020

Conversation

FJBDev
Copy link
Collaborator

@FJBDev FJBDev commented Dec 11, 2019

  • French translation fixes/updates



  • Bugfix: Disabling the "Edit Marker" in the slice editor view if an existing marker hasn't been selected (see commit ed669ff)
    image



  • Fixed a regression that appeared in 19.3.0 (maybe due to the update to Eclipse 4.10 as the file PrefPageGeneral.java had not been changed between 18.13 and 19.3.0 ?)
    (see commit a76bde9)

image

20.Next.0 :
image



  • Fixed bugs in the Computed values preference page (Break Time and Elevation Gain tabs) where the speed and altitude were not properly converted when switching between metric and imperial system units
    The default DPT value is 7m (22.9 ft) and the conversion is not done when using the imperial system in MTB
    (see commit 52334e5)

image

20.Next.0 :
image



  • Added the ability to retrieve the weather by clicking on the hyperlink in the Tour Editor View (see commit 080c955)
    image



  • NPE fix : After deleting a tag, the tour tag profiles were not updated and if the recently deleteg tag was present in tour tag profiles, an NPE would appear (see commit e3bfe02)

See in my screenshot below : the profile vbfdbfd has 1 tag but nothing is displayed because the tag was just deleted. Therefore, the NPE appears below
image



  • Fixed a bug when editing time slices or swim slices in the TourDataEditorView (see commit f4b7492)
    Scenario to reproduce :

    • Open the tour editor of a given tour and click on the "Time Slices" tab.
    • Edit a value (HR or altitude or cadence etc....)
    • Save the tour => the new value appears in the time slice
    • Edit the same value and change it to a new value and remove the focus on the cell (press TAB for example) ==> the new value doesn't appear but instead the old value appears.



  • 3rd party library updates (see commit 3b24190)
    Updated of all the referenced jar libraries as it's something nice to have as typically those new libraries bring

  • Replaced the "" occurrences with UI.EMPTY_STRING (see commit 7dcbd4e)



  • Time slices window enhancements to offer the ability to efficiently edit specific values of Altitude/Pulse/Cadence/Temperature. Those values can be quickly found thanks to the added ability to sort those columns in ascending/descending order. (see commit 7acee1e)

    • Added a contextual menu in the Time slices tab of the Tour Editor view. Upon the selection of 1 or more rows, the time slice editor will allow to replace or offset the Altitude/Pulse/Cadence/Temperature
      image
      image

    • Added the ability to sort the Time Slice Index/Altitude/Pulse/Cadence/Temperature columns.
      image

(It can potentially address this feature request)




  • FIT: Fixed NPE when importing files with developer fields that are null (see commit 97b3755)



  • Tour Marker View - Added the following columns :
    Elevation Gain Difference, Elevation Loss Difference, Pace Difference
    @wolfgang-ch Especially look at TourData.java and how I reworked computeAltitudeUpDown(). I am open to better suggestions
    (see commit 6d3c869)
    image




  • Photos View :
    Fixed NPE when no folder is selected and a filter is applied (see commit c41e6fc)
java.lang.NullPointerException
	at net.tourbook.photo.ImageGallery.jobFilter_32_RunSubsequent(ImageGallery.java:1823)
	at net.tourbook.photo.ImageGallery.access$32(ImageGallery.java:1805)
	at net.tourbook.photo.ImageGallery$20.run(ImageGallery.java:1540)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)




  • Compare Results View: Added the ability, in the Views Preference Page to show/hide the tour tooltip in the Tour Compare Result View (see commit c1568ed)

image

FJBDev and others added 27 commits January 9, 2020 23:47
…levation Loss Difference, Pace Difference (#10)

* WIP here

* 20.X as of 20200110 (#9)

* French translation

* French typo fix

* fixed issue: column width are reset when tags are saved

* Fixed issue in statistics: Tour type in tooltip is wrong for the first item

* java template update: removed parentheses

* Show tooltip for the bottom bars, the hitbox for the horizontal slider starts now below the horizontal line (for a bar chart)

* reported map2 bug

* Adding the cadence zones time percentages in the weekly summary of the
calendar

* removed useless code

* Unique function to generate the string containing the percentages of
time spent in each cadence zone

* French translation fix

* fixed bikerWeight value in gpx export

had to use getBodyWeight() method because accessing the field didn't work -> very strange

* fixed NPE when importing MT export files

* GPX import: Set default to absolute distance that the defaults for export/import are the same

* readme update

* MTB cheatsheet

* MT cheatsheet

* Revert "MTB cheatsheet"

This reverts commit f624320.

* Adding TODO for next version (Linux tile saving issue)

* Per review suggestion

* FIT import: Starting marker label from 1 instead of 0

* WIP Issues in the General men values when switching from metric to
implerial and vice versa

* WIP Elevation gain and loss can be wrong at times

* Using a java library but obtaining similar results

* Removing the series reducer

* Clean up

* WIP Fixing a bug where the metric radio buttons disappeared

* Not much progress

* Fixed the UI for the measurement system tab

* Cleanup

* Reverting for less commit "noise"

* Conversion fix

* Typo

* Updated Readme

* dutch translation

* Disabling the "Edit Marker" in the slice editor view if an existing
marker hasn't been selected

* No need to convert the tolerance DP in this case

* Updating to Eclipse 4.14 (2019-12)

* Displaying the + if altitude was added after computing the elevation
gain

* Displaying the + while computing the new elevation gain values.

* Displaying the tolerance in the current measurement system and with the
system unit

* 2020 todo's

* French translation improvements and fixes

* Adding the tour type header "T"

* removed old info

* dutch translation

* French translation fixes

* French translation

* Adding the ability to retrieve the weather with 1 click from the Tour
Edit View

* Misc

* 20.X readme update

* French typo

* French typos

* updated p2 NL repo readme

* French translation

* NPE fix : After deleting tag(s), if they were part of a tour tag filter
they need to be removed from the tour tag profile

* French translation fixes

* TourDataEditorView: Fixed a bug where after editing a value and saving
the tour, the next edit of a value will not be taken into account

* 20.X readme update

* 3rd party library updates (#7)

* Xstream library 1.3.1 to 1.4.11.1

* Updating org.json library 20160212 to 20190722

* Updating lat-lon-timezone-converter from 2016-05-04 to 2019-04-30

* Updating edtftpj from 2.0.3 to 2.5.0

* Updating from jackson 2.9.9 to 2.10.0

* Updating Joda Time from 2.9.4 to 2.10.4

* Clean-up

* Updating Apache Commons Imaging from 0.97 to 1.0-alpha1

* Forgot to remove the old library

* Updating from trove 3.0.2 to 3.1.0

* Updating from xpp3 1.1.4c to 1.1.6

* WIP Migrating from ConcurrentLinkedHashMap to its successor Caffeine

* Found a way to resize the cache

* WIP Updating from c3p0-0.9.1.2 to 0.9.5.4

* Reverting WIP Updating from c3p0-0.9.1.2 to 0.9.5.4 as it is used in
ext.ejb

* Adding the library maven links for future reference

* Forgot this file

* Updated links to quickly find the maven repo

* Updating from commons-logging-1.0.4 to 1.2 & from commons-io-1.3.1 to
2.6

* Updating xmlgraphics-commons from 1.3.1 to 2.4

* Updating jaxb-api from 2.3.0 to 2.4.0

* Updating batik-all from 1.7 to 1.12

* Updating fop from 0.95 to 2.4.0

* Updating from avalon-framework 4.2.0 to 4.3.1

* spaces

* Updating all the geoclipse libraries

* Misc

* French translation

* Replacing the "" with UI.EMPTY_STRING

* Better french translation

* Timeslices enhancement (#8)

* Xstream library 1.3.1 to 1.4.11.1

* Updating org.json library 20160212 to 20190722

* Updating lat-lon-timezone-converter from 2016-05-04 to 2019-04-30

* Updating edtftpj from 2.0.3 to 2.5.0

* Updating from jackson 2.9.9 to 2.10.0

* Updating Joda Time from 2.9.4 to 2.10.4

* Clean-up

* Updating Apache Commons Imaging from 0.97 to 1.0-alpha1

* Forgot to remove the old library

* Updating from trove 3.0.2 to 3.1.0

* Updating from xpp3 1.1.4c to 1.1.6

* WIP Migrating from ConcurrentLinkedHashMap to its successor Caffeine

* Found a way to resize the cache

* WIP Updating from c3p0-0.9.1.2 to 0.9.5.4

* Reverting WIP Updating from c3p0-0.9.1.2 to 0.9.5.4 as it is used in
ext.ejb

* Adding the library maven links for future reference

* Forgot this file

* Updated links to quickly find the maven repo

* WIP Time Slices edit values

* WIP Time Slices edit values Part2

* WIP Time Slices edit values Part3

* WIP Time Slices edit values Part4

* WIP Time Slices edit values Part5

* WIP Time Slices edit values Part6

* A small update

* Trying to highlight the modified rows

* Struggling with selecting several rows

* Found how to highlight multiple rows!

* VERY important to put it after the fireTourModification!

* Clean reselection after having updated the values

* WIP Time Slices edit values Part8

* Updating from commons-logging-1.0.4 to 1.2 & from commons-io-1.3.1 to
2.6

* Updating xmlgraphics-commons from 1.3.1 to 2.4

* Updating jaxb-api from 2.3.0 to 2.4.0

* Updating batik-all from 1.7 to 1.12

* Updating fop from 0.95 to 2.4.0

* Updating from avalon-framework 4.2.0 to 4.3.1

* spaces

* Updating all the geoclipse libraries

* A bit more work o the edit dialog

* UI work

* More UI progress

* Still tinkering with the UI (back to radio buttons for the fields ?)

* UI work

* UI getting close to being done

* Getting close to the end

* Work completed

* WIP Sorting time slice editor columns

* Misc

* Elevationgain computationfix (#2)

* French translation improvements and fixes

* Adding the tour type header "T"

* French translation fixes

* French translation

* Adding the ability to retrieve the weather with 1 click from the Tour
Edit View

* Misc

* 20.X readme update

* French typo

* French typos

* Editvalues timeslices (#3)

* French translation improvements and fixes

* Adding the tour type header "T"

* French translation fixes

* French translation

* Adding the ability to retrieve the weather with 1 click from the Tour
Edit View

* Misc

* 20.X readme update

* French typo

* French typos

* WIP Sorting columns

* Test

* Elevationgain computationfix (#4)

* French translation improvements and fixes

* Adding the tour type header "T"

* French translation fixes

* French translation

* Adding the ability to retrieve the weather with 1 click from the Tour
Edit View

* Misc

* 20.X readme update

* French typo

* French typos

* Elevationgain computationfix (#5)

* French translation improvements and fixes

* Adding the tour type header "T"

* French translation fixes

* French translation

* Adding the ability to retrieve the weather with 1 click from the Tour
Edit View

* Misc

* 20.X readme update

* French typo

* French typos

* The column sorting works on the heart rate column!

* Clean-up

* Replacing the "" with UI.EMPTY_STRING

* WIP editing sorted columns

* WIP

* WIP : Sorting time slices editor columns

* WIP Sorting and editing time slices columns

* We can now sort by the index column

* Feature testing and clean-up

* Bugfix for when offsetting fahrenheit temperatures

* Not applicable

* We disable the edit time slices menu if the view is in readonly mode

* Updated 20.X readme

Co-authored-by: Wolfgang Schramm <wolfgang-ch@users.noreply.github.com>

* WIP : Adding elevation gain and pace between 2 markers

* Typos

* WIP : Adding the delta elevation gain loss and delta pace in the tour
marker view

* Idea

* Tour Marker-Added the following columns Elevation Gain Difference,
Elevation Loss Difference, Pace Difference

* Index fix

* Better

Co-authored-by: Wolfgang Schramm <wolfgang-ch@users.noreply.github.com>
* WIP : Add the ability to hide the tour tooltip in the
TourCompareResultView

* Part2
@wolfgang-ch wolfgang-ch merged commit 953972d into mytourbook:FJBDev Feb 2, 2020
@FJBDev FJBDev changed the title MTB 20.X features & bugfixes & french translation MTB 20.2 features & bugfixes & french translation Feb 18, 2020
@FJBDev FJBDev changed the title MTB 20.2 features & bugfixes & french translation MT 20.2 features & bugfixes & french translation Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants