Skip to content

Commit

Permalink
ENGR00255482 ASoC: HDMI-audio: Add error message for HDMI-video detec…
Browse files Browse the repository at this point in the history
…t failure

  HDMI-audio depends on HDMI-video. If users want to use HDMI-audio function,
they need to load HDMI-video first. Sometime users would forget to put video
info into U-boot cmdline, "video=mxcfb0:dev=hdmi,1920x1080M@60,if=RGB24" for
example. That might cause HDMI-auido driver fail to detect HDMI-video.
  Previously, if this happened to system, driver only returned with "ENOMEM"
and system would print "Can't allocate memory". This might confuse users due
to the vague infomation. Users would be hard to figure out the root cause.
  So this patch just add some error message to give users a clear indication,
and changed the "ENOMEM" error number to the more precise "ENODEV".

Acked-by: Wang Shengjiu <b02247@freescale.com>
Signed-off-by: Nicolin Chen <b42378@freescale.com>
  • Loading branch information
Nicolin Chen committed Mar 22, 2013
1 parent 7ba5b60 commit 9eb05b3
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
8 changes: 5 additions & 3 deletions sound/soc/imx/imx-hdmi-dai.c
@@ -1,7 +1,7 @@
/*
* ALSA SoC HDMI Audio Layer for MXS
*
* Copyright (C) 2011-2012 Freescale Semiconductor, Inc.
* Copyright (C) 2011-2013 Freescale Semiconductor, Inc.
*
* Based on stmp3xxx_spdif_dai.c
* Vladimir Barinov <vbarinov@embeddedalley.com>
Expand Down Expand Up @@ -42,8 +42,10 @@ static int imx_hdmi_dai_probe(struct platform_device *pdev)
struct imx_hdmi *hdmi_data;
int ret = 0;

if (!hdmi_get_registered())
return -ENOMEM;
if (!hdmi_get_registered()) {
dev_err(&pdev->dev, "Failed: Load HDMI-video first.\n");
return -ENODEV;
}

hdmi_data = kzalloc(sizeof(*hdmi_data), GFP_KERNEL);
if (!hdmi_data)
Expand Down
8 changes: 5 additions & 3 deletions sound/soc/imx/imx-hdmi.c
@@ -1,7 +1,7 @@
/*
* ASoC HDMI Transmitter driver for IMX development boards
*
* Copyright (C) 2011-2012 Freescale Semiconductor, Inc.
* Copyright (C) 2011-2013 Freescale Semiconductor, Inc.
*
* based on stmp3780_devb_spdif.c
*
Expand Down Expand Up @@ -57,8 +57,10 @@ static int __init imx_hdmi_init(void)
{
int ret = 0;

if (!hdmi_get_registered())
return -ENOMEM;
if (!hdmi_get_registered()) {
pr_err("Initialize HDMI-audio failed. Load HDMI-video first!\n");
return -ENODEV;
}

imx_hdmi_snd_device = platform_device_alloc("soc-audio", 4);
if (!imx_hdmi_snd_device) {
Expand Down

0 comments on commit 9eb05b3

Please sign in to comment.