Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls-cipher fix #17859

Merged
merged 4 commits into from
Apr 26, 2024
Merged

tls-cipher fix #17859

merged 4 commits into from
Apr 26, 2024

Conversation

developer-guy
Copy link
Member

@developer-guy developer-guy commented Apr 26, 2024

Fixes: argoproj/argo-cd#17569

Important

Once the change that was made by Josh released we should remove the patch file and update the argo-cd version but today instead of waiting the release we applied that change as a patch file**

/cc @joshrwolf @mamccorm

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
Co-authored-by: Furkan Turkal <furkan.turkal@chainguard.dev>
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
@xnox
Copy link
Contributor

xnox commented Apr 26, 2024

everything looks fine, apart from editor settings, can you please run yam on the yaml file?

Signed-off-by: James Petersen <jpetersenames@gmail.com>
@found-it
Copy link
Contributor

found-it commented Apr 26, 2024

I went ahead and ran yam, thanks for putting this together @developer-guy!

Signed-off-by: James Petersen <jpetersenames@gmail.com>
@xnox xnox merged commit a4cbb3c into wolfi-dev:main Apr 26, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants