-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more JDK deps, libxt, libusb, libevent, dbus, libpaper, cups #48
Conversation
Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
cups.yaml
Outdated
# - poppler-utils do we need this? | ||
# - libjpeg-turbo-dev do we need this? | ||
# - avahi-dev do we need this? | ||
# - gnutls-dev do we need this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about these four packages. Compiling seems fine as well as downstream packages that uses this.
If we don't need these I'll remove them from this PR or add a TODO. If we do need these I'll need to create them as I've not done that yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need them for CUPS to be actually useful for printing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok cool - I'll do those too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now we could unblock JDK and address TODOs in a followup #49
dbus.yaml
Outdated
- meson | ||
- xmlto | ||
- bash | ||
# - glib-dev # TODO do we need this? This and downstream packages are compiling fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure about glib-dev
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for the libdbus-glib dependency, which is obsolete but still used by some software.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sounds good, will package glib-dev too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now we could unblock JDK and address TODOs in a followup #49
Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
Signed-off-by: James Rawlings <jrawlings@chainguard.dev>
Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
Signed-off-by: James Rawlings jrawlings@chainguard.dev