New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing libs #2
Missing libs #2
Conversation
Hey Anselm, did you try Anyway, I am really glad you liked it and I will merge your pull request as soon as I got my main computer back from the repairshop -- since your argumentation is logical and it really shouldn't add all that clutter. (I am gonna mergee it later because I don't fully trust the auto merge button from github :) If you want to help making the markdowneditor field better, you are very welcome! Very cool would also be an integration with the core silverstripe popups and stuff, but I couldn't wrap my head around this last time I did work on the module and also the popups looked quite a bit unfinished. Another thing I am planning to fix is a easy way to decorate a DataObject with a This way, it would be possible to replace the links to images and sites with the right shortcode so Image and Link tracking would be functional again... Just laying out my plans :) I still don't have an actual website where I use it, because everytime I try to design my own website, I never am able to finish it -- to many new ideas ... ;) |
Looks like i have missed out a |
Sounds awesome. And regarding the ACE source, we could/should probably also remove all those mode and theme files that are not needed, and that way keep the module code lean. Another thing would be to add those sources in the readme in order to keep later updating less painful (though for now it's documented here). Let me know when you've had time to add those images back in, and I'll update my branch! Looking forward to see this developing and helping out! |
Hi @wolfv, out of usability considerations I've decided not to use the markdown field on the client project I'm currently working on. I had been developing a |
Wolfv, great work on the module. I'm seing some great potential in this. Especially what you've got goin on with the suggest link and suggest image feature!
I had some trouble getting it to work initially, as something must have gotten messed up with the submodules you were using. The modules point nowhere, so the markdown libs and the ACE are not part of the downloaded repo.
I did a little guessing and trial and error, and added those manually, after deleting the submodule stubs (as explained here - in the bottom):
Furthermore the
images
directory is not part of the repo either. Just to let you know.If you'd rather want to use those submodules (can't make up my mind what's best, as that way a lot of unnecessary files are added, especially from the ACE builds), feel free to go ahead and just close this request!