feat: Initial version #1

wolfy1339 · 2022-06-27T00:33:49Z

No description provided.

gr2m

It might be simpler to use https://github.com/gr2m/octokit-plugin-create-pull-request?

script.js

wolfy1339 · 2022-06-28T02:48:34Z

It might be simpler to use https://github.com/gr2m/octokit-plugin-create-pull-request?

Indeed it is much simpler!

In order to get the file name

- Decode the content before using it - It's Array#push() not Array#append() - It's BREAKING CHANGE, why can't the plural also be used

wolfy1339 · 2022-06-28T16:31:52Z

I only seem to have one problem with the script.

The endpoint /repos/{owner}/{repository}/git/trees returns a 404 when trying to do a POST request (via octokit-plugin-create-pull-request)

Here's an extract of the log for the failed request

{
    "repository": {
        "id": 366884413,
        "owner": {
            "login": "wolfy1339",
            "id": 4595477,
            "node_id": "MDQ6VXNlcjQ1OTU0Nzc=",
            "avatar_url": "https://avatars.githubusercontent.com/u/4595477?v=4",
            "gravatar_id": "",
            "url": "https://api.github.com/users/wolfy1339",
            "html_url": "https://github.com/wolfy1339",
            "followers_url": "https://api.github.com/users/wolfy1339/followers",
            "following_url": "https://api.github.com/users/wolfy1339/following{/other_user}",
            "gists_url": "https://api.github.com/users/wolfy1339/gists{/gist_id}",
            "starred_url": "https://api.github.com/users/wolfy1339/starred{/owner}{/repo}",
            "subscriptions_url": "https://api.github.com/users/wolfy1339/subscriptions",
            "organizations_url": "https://api.github.com/users/wolfy1339/orgs",
            "repos_url": "https://api.github.com/users/wolfy1339/repos",
            "events_url": "https://api.github.com/users/wolfy1339/events{/privacy}",
            "received_events_url": "https://api.github.com/users/wolfy1339/received_events",
            "type": "User",
            "site_admin": false
        },
        "name": "test-repository"
    },
    "msg": "HttpError: Not Found\n    at /home/user/Desktop/Programming/octoherd-remove-eol-node-versions/node_modules/@octokit/request/dist-node/index.js:86:21\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)\n    at async Job.doExecute (/home/user/Desktop/Programming/octoherd-remove-eol-node-versions/node_modules/bottleneck/light.js:405:18)",
    "name": "HttpError",
    "status": 404,
    "response": {
        "url": "https://api.github.com/repos/wolfy1339/test-repository/git/trees",
        "status": 404,
        "headers": {
            "access-control-allow-origin": "*",
            "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset",
            "connection": "close",
            "content-encoding": "gzip",
            "content-security-policy": "default-src 'none'",
            "content-type": "application/json; charset=utf-8",
            "date": "Tue, 28 Jun 2022 16:22:38 GMT",
            "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
            "server": "GitHub.com",
            "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
            "transfer-encoding": "chunked",
            "vary": "Accept-Encoding, Accept, X-Requested-With",
            "x-accepted-oauth-scopes": "",
            "x-content-type-options": "nosniff",
            "x-frame-options": "deny",
            "x-github-media-type": "github.v3; format=json",
            "x-github-request-id": "8C9A:5A0B:3870ED0:6EBC003:62BB2ACE",
            "x-oauth-scopes": "notifications, public_repo, read:discussion, read:enterprise, read:gpg_key, read:org, read:packages, read:public_key, read:repo_hook, read:user, repo:status, repo_deployment, user:email",
            "x-ratelimit-limit": "5000",
            "x-ratelimit-remaining": "4874",
            "x-ratelimit-reset": "1656433380",
            "x-ratelimit-resource": "core",
            "x-ratelimit-used": "126",
            "x-xss-protection": "0"
        },
        "data": {
            "message": "Not Found",
            "documentation_url": "https://docs.github.com/rest/reference/git#create-a-tree"
        }
    },
    "request": {
        "method": "POST",
        "url": "https://api.github.com/repos/wolfy1339/test-repository/git/trees",
        "headers": {
            "accept": "application/vnd.github.v3+json",
            "user-agent": "octoherd-cli/3.4.8 octoherd-cli/2.3.1 octokit-core.js/3.6.0 Node.js/16.15.0 (linux; x64)",
            "authorization": "token [REDACTED]",
            "content-type": "application/json; charset=utf-8"
        },
        "body": "{\"base_tree\":\"ea0e827bafdec61e54000a8631941f383f6dbdc6\",\"tree\":[{\"path\":\".github/workflows/test.yml\",\"mode\":\"100644\",\"content\":\"name: Test\\n\\\"on\\\":\\n  push:\\n    branches:\\n      - master\\n  pull_request:\\n    types:\\n      - opened\\n      - synchronize\\njobs:\\n  test_matrix:\\n    runs-on: ubuntu-latest\\n    strategy:\\n      matrix:\\n        node_version:\\n          - 14\\n          - 16\\n          - 18\\n    steps:\\n      - uses: actions/checkout@v3\\n      - name: \\\"Use Node.js ${{ matrix.node_version }}\\\"\\n        uses: actions/setup-node@v3\\n        with:\\n          node-version: \\\"${{ matrix.node_version }}\\\"\\n          cache: npm\\n      - run: npm ci\\n      - run: npm test\\n\\n  test:\\n    runs-on: ubuntu-latest\\n    needs: test_matrix\\n    steps:\\n      - uses: actions/checkout@v3\\n      - run: npm ci\\n      - run: npm run test:typescript\\n      - run: npm run lint\\n\"}]}",
        "request": {}
    },
    "level": "error",
    "time": 1656433358280
}

script.js

oscard0m · 2022-07-07T20:09:12Z

script.js

+  const pr = await composeCreatePullRequest(octokit, {
+    owner,
+    repo,
+    title: `ci: stop testing against NodeJS ${NODE_VERSIONS_STRING}`,
+    body: `BREAKING CHANGE: Drop support for NodeJS ${NODE_VERSIONS_STRING}`,
+    head: branchName,
+    changes,
+    createWhenEmpty: false,
+    update: true
+  });
+
+
+  if (pr)
+    octokit.log.info(`Pull request created: ${pr.data.html_url}`);


Should we wrap this in a try-catch and ocotkit.log.error accordingly or do we want to just throw?

I don't think it's warranted

oscard0m · 2022-07-07T20:12:20Z

I only seem to have one problem with the script.

The endpoint /repos/{owner}/{repository}/git/trees returns a 404 when trying to do a POST request (via octokit-plugin-create-pull-request)

Here's an extract of the log for the failed request

Click to expand!

  {
  "repository": {
      "id": 366884413,
      "owner": {
          "login": "wolfy1339",
          "id": 4595477,
          "node_id": "MDQ6VXNlcjQ1OTU0Nzc=",
          "avatar_url": "https://avatars.githubusercontent.com/u/4595477?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/wolfy1339",
          "html_url": "https://github.com/wolfy1339",
          "followers_url": "https://api.github.com/users/wolfy1339/followers",
          "following_url": "https://api.github.com/users/wolfy1339/following{/other_user}",
          "gists_url": "https://api.github.com/users/wolfy1339/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/wolfy1339/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/wolfy1339/subscriptions",
          "organizations_url": "https://api.github.com/users/wolfy1339/orgs",
          "repos_url": "https://api.github.com/users/wolfy1339/repos",
          "events_url": "https://api.github.com/users/wolfy1339/events{/privacy}",
          "received_events_url": "https://api.github.com/users/wolfy1339/received_events",
          "type": "User",
          "site_admin": false
      },
      "name": "test-repository"
  },
  "msg": "HttpError: Not Found\n    at /home/user/Desktop/Programming/octoherd-remove-eol-node-versions/node_modules/@octokit/request/dist-node/index.js:86:21\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)\n    at async Job.doExecute (/home/user/Desktop/Programming/octoherd-remove-eol-node-versions/node_modules/bottleneck/light.js:405:18)",
  "name": "HttpError",
  "status": 404,
  "response": {
      "url": "https://api.github.com/repos/wolfy1339/test-repository/git/trees",
      "status": 404,
      "headers": {
          "access-control-allow-origin": "*",
          "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset",
          "connection": "close",
          "content-encoding": "gzip",
          "content-security-policy": "default-src 'none'",
          "content-type": "application/json; charset=utf-8",
          "date": "Tue, 28 Jun 2022 16:22:38 GMT",
          "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
          "server": "GitHub.com",
          "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
          "transfer-encoding": "chunked",
          "vary": "Accept-Encoding, Accept, X-Requested-With",
          "x-accepted-oauth-scopes": "",
          "x-content-type-options": "nosniff",
          "x-frame-options": "deny",
          "x-github-media-type": "github.v3; format=json",
          "x-github-request-id": "8C9A:5A0B:3870ED0:6EBC003:62BB2ACE",
          "x-oauth-scopes": "notifications, public_repo, read:discussion, read:enterprise, read:gpg_key, read:org, read:packages, read:public_key, read:repo_hook, read:user, repo:status, repo_deployment, user:email",
          "x-ratelimit-limit": "5000",
          "x-ratelimit-remaining": "4874",
          "x-ratelimit-reset": "1656433380",
          "x-ratelimit-resource": "core",
          "x-ratelimit-used": "126",
          "x-xss-protection": "0"
      },
      "data": {
          "message": "Not Found",
          "documentation_url": "https://docs.github.com/rest/reference/git#create-a-tree"
      }
  },
  "request": {
      "method": "POST",
      "url": "https://api.github.com/repos/wolfy1339/test-repository/git/trees",
      "headers": {
          "accept": "application/vnd.github.v3+json",
          "user-agent": "octoherd-cli/3.4.8 octoherd-cli/2.3.1 octokit-core.js/3.6.0 Node.js/16.15.0 (linux; x64)",
          "authorization": "token [REDACTED]",
          "content-type": "application/json; charset=utf-8"
      },
      "body": "{\"base_tree\":\"ea0e827bafdec61e54000a8631941f383f6dbdc6\",\"tree\":[{\"path\":\".github/workflows/test.yml\",\"mode\":\"100644\",\"content\":\"name: Test\\n\\\"on\\\":\\n  push:\\n    branches:\\n      - master\\n  pull_request:\\n    types:\\n      - opened\\n      - synchronize\\njobs:\\n  test_matrix:\\n    runs-on: ubuntu-latest\\n    strategy:\\n      matrix:\\n        node_version:\\n          - 14\\n          - 16\\n          - 18\\n    steps:\\n      - uses: actions/checkout@v3\\n      - name: \\\"Use Node.js ${{ matrix.node_version }}\\\"\\n        uses: actions/setup-node@v3\\n        with:\\n          node-version: \\\"${{ matrix.node_version }}\\\"\\n          cache: npm\\n      - run: npm ci\\n      - run: npm test\\n\\n  test:\\n    runs-on: ubuntu-latest\\n    needs: test_matrix\\n    steps:\\n      - uses: actions/checkout@v3\\n      - run: npm ci\\n      - run: npm run test:typescript\\n      - run: npm run lint\\n\"}]}",
      "request": {}
  },
  "level": "error",
  "time": 1656433358280
}

Did you find out what was the issue with this? Do you need any help on debugging/reproducing this? @wolfy1339

wolfy1339 · 2022-07-07T20:35:32Z

The 404s are gone now!

There is another case of outdated node versions where it isn't in a matrix, however those can be manually fixed

wolfy1339 · 2022-07-07T20:35:55Z

Here's an example of what the output is: wolfy1339/test-repository-test#10

oscard0m · 2022-07-07T20:38:31Z

Here's an example of what the output is: wolfy1339/test-repository#10

LGTM!

wolfy1339 added 8 commits June 26, 2022 20:30

docs(README): remove WIP note

ff66b96

build(package): initial version

d8d87a2

build(package): lock file

4eca2c4

build(gitignore): node_modules

3a7b376

feat: initial version

eb6ca6f

chore(lint): add eslint config

88596dd

feat(script): initial behaviour

376a87a

feat: narrow implementation

8a9bd81

wolfy1339 mentioned this pull request Jun 27, 2022

Remove Node version 10 from .github/workflows/test.yml octokit/oauth-app.js#299

Closed

gr2m reviewed Jun 27, 2022

View reviewed changes

script.js Outdated Show resolved Hide resolved

wolfy1339 added 2 commits June 27, 2022 22:46

refactor: rewrite script to use octokit-plugin-create-pull-request

54151d5

chore(eslintrc): set ecmaVersion to 2021

a7bac57

wolfy1339 added 3 commits June 27, 2022 23:02

fix: correct typo in Array#includes() function call

6e22ded

fix: pass through file object

766ad2f

In order to get the file name

fix: little fixes

27f4a4c

- Decode the content before using it - It's Array#push() not Array#append() - It's BREAKING CHANGE, why can't the plural also be used

wolfy1339 added 2 commits June 28, 2022 18:10

build(deps): update octokit-plugin-create-pull-request

f8c36c3

fix: allow to update existing PRs

11bb10a

oscard0m reviewed Jul 7, 2022

View reviewed changes

wolfy1339 added 2 commits July 7, 2022 16:20

fix: don't look at a particular file, look at the directory

53e79e9

fix: convert content to text even if the file isn't modified

1efdbec

oscard0m approved these changes Jul 7, 2022

View reviewed changes

wolfy1339 merged commit e9d31be into main Jul 7, 2022

wolfy1339 deleted the initial-version branch July 7, 2022 20:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Initial version #1

feat: Initial version #1

wolfy1339 commented Jun 27, 2022

gr2m left a comment

wolfy1339 commented Jun 28, 2022

wolfy1339 commented Jun 28, 2022 •

edited

oscard0m Jul 7, 2022

wolfy1339 Jul 7, 2022

oscard0m commented Jul 7, 2022

wolfy1339 commented Jul 7, 2022

wolfy1339 commented Jul 7, 2022

oscard0m commented Jul 7, 2022 •

edited

feat: Initial version #1

feat: Initial version #1

Conversation

wolfy1339 commented Jun 27, 2022

gr2m left a comment

Choose a reason for hiding this comment

wolfy1339 commented Jun 28, 2022

wolfy1339 commented Jun 28, 2022 • edited

oscard0m Jul 7, 2022

Choose a reason for hiding this comment

wolfy1339 Jul 7, 2022

Choose a reason for hiding this comment

oscard0m commented Jul 7, 2022

wolfy1339 commented Jul 7, 2022

wolfy1339 commented Jul 7, 2022

oscard0m commented Jul 7, 2022 • edited

wolfy1339 commented Jun 28, 2022 •

edited

oscard0m commented Jul 7, 2022 •

edited