Skip to content

Commit

Permalink
improve coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
wollmers committed Apr 28, 2015
1 parent c76da77 commit db90ce7
Show file tree
Hide file tree
Showing 5 changed files with 47 additions and 16 deletions.
1 change: 1 addition & 0 deletions Changes
@@ -1,6 +1,7 @@
Revision history for Mojolicious-Plugin-Form.

{{$NEXT}}
- improve coverage

0.006 2015-04-07 16:30:03 CEST
- add badges in pod
Expand Down
1 change: 1 addition & 0 deletions cpanfile
Expand Up @@ -6,4 +6,5 @@ requires 'Mojolicious', '4.0';

on test => sub {
requires 'Test::More', '0.88';
requires 'Test::Carp', '0';
};
6 changes: 1 addition & 5 deletions lib/Mojolicious/Plugin/Form.pm
Expand Up @@ -22,8 +22,7 @@ sub register {
my $namespace = ref($self->app) . '::Form::';
$namespace = '' if $namespace =~ m/^Mojolicious::Lite/;

$class_name = join '' => $namespace,
Mojo::ByteStream->new($class_name)->camelize;
$class_name = Mojo::ByteStream->new($class_name)->camelize;
}

$class_name = $namespace . $class_name;
Expand All @@ -36,9 +35,6 @@ sub register {

Carp::croak qq/Can't find form '$class_name'/ if $e;

#Carp::croak qq/Wrong form '$class_name' isa /.ref($self->app) . '::Form'
# unless $class_name->isa(ref($self->app) . '::Form');

return $class_name->new(%$conf, @_);
}
);
Expand Down
23 changes: 21 additions & 2 deletions t/01_app_base.t
Expand Up @@ -9,6 +9,8 @@ use Data::Dumper;
use Test::More;
END { done_testing(); }

use Test::Carp;

use Test::Mojo;

use_ok('MyApp');
Expand All @@ -29,6 +31,23 @@ my $source = $sources[0];

ok($source, 'MyApp source');

my $table = $schema->class($source)->table;
#my $table = $schema->class($source)->table;

ok($schema->class($source)->table, 'MyApp table');

#my $form_handler = $t->app->form_handler('Foo');

ok($t->app->form_handler('Foo'), 'MyApp form_handler');

ok($t->app->form_handler('Foo',{a => 1}), 'MyApp form_handler with params');

ok($t->app->form_handler('foo'), 'MyApp form_handler lowercase');

does_croak( sub { $t->app->form_handler('Blah') } );

#does_croak( sub { $t->app->form_handler('Defect') } );

does_croak( sub { $t->app->form_handler() } );



ok($table, 'MyApp table');
32 changes: 23 additions & 9 deletions t/lib/MyApp.pm
Expand Up @@ -43,18 +43,32 @@ sub class {
return $self->entries->{$source};
};

package MySchema::Class;
use Mojo::Base -base;
package MySchema::Class {
use Mojo::Base -base;

has 'table';
1;
}

package MyApp::Form {
use Mojo::Base 'Mojolicious::Plugin::Form::Base';
1;
}

has 'table';
package MyApp::Form::Foo {
use Mojo::Base 'MyApp::Form';
1;
}

package MyApp::Form;
use Mojo::Base 'Mojolicious::Plugin::Form::Base';
package MyApp::Form::Bar {
use Mojo::Base 'MyApp::Form';
1;
}

package MyApp::Form::Foo;
use Mojo::Base 'MyApp::Form';
package MyApp::Form::Defect {
use Mojo::Base 'MyApp::Form';

package MyApp::Form::Bar;
use Mojo::Base 'MyApp::Form';
0; # TODO
}

1;

0 comments on commit db90ce7

Please sign in to comment.