Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I found the background can not set as pure COlors.white? #139

Closed
luohao123 opened this issue Feb 9, 2024 · 7 comments · Fixed by #156
Closed

I found the background can not set as pure COlors.white? #139

luohao123 opened this issue Feb 9, 2024 · 7 comments · Fixed by #156

Comments

@luohao123
Copy link

It will override by another tint color,

cosnider support it and fix it?

@ulusoyca
Copy link
Collaborator

ulusoyca commented Feb 9, 2024

At Wolt we are using pure white. Can you share a screenshot? Alternatively, to be on the safe side, you can set the tint color to be transparent in the theme data extension as in this example

image

@luohao123
Copy link
Author

@ulusoyca Am using themeData with useMaterial=3, and with a theme seed of Colors.purple.

So when I set COlors.red as background color, it works, but when set pure white, it will always overwrite.

@ulusoyca
Copy link
Collaborator

@luohao123 Have you tried to set the surfaceTintColor to Colors.transparent

@yusufnadar
Copy link
Contributor

yusufnadar commented Mar 1, 2024

@luohao123 I was getting the same error, but after defining what @ulusoyca suggested it worked. Thanks. This is my code:

AppTheme.defaultTheme: ThemeData(
fontFamily: FontFamily.euclidCircularBRegular,
scaffoldBackgroundColor: AppColors.scaffoldBgColor,
).copyWith(
extensions: const [
WoltModalSheetThemeData(
modalBarrierColor: Colors.transparent,
backgroundColor: Colors.white,
surfaceTintColor: Colors.transparent,
mainContentScrollPhysics: ClampingScrollPhysics(),
),
],
),

@ulusoyca
Copy link
Collaborator

ulusoyca commented Mar 3, 2024

There is a fix by @yusufnadar . You can set the surfaceTintColor to Colors.transparent to avoid this. It will be released next week.

@luohao123
Copy link
Author

@ulusoyca thanks, does it works in pub.dev?

Does surffaceIntColor can set in Walt widget rather than using themeData?

@luohao123
Copy link
Author

BTW, wanna further ask, does it support some bouncing pop up animation built-in in walt? I really want the animation more smooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants