Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default Clip Behavior to antiAliasWithSaveLayer to fix Top Bar rendering issue #164

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

ulusoyca
Copy link
Collaborator

Description

This PR updates the default clip behavior of the WoltModalSheet from Clip.antiAlias to Clip.antiAliasWithSaveLayer. The change addresses a rendering issue where a thin border was visible at the top bar of the modal sheet, which was not the intended design.

Changes

Modified the clipBehavior getter in WoltModalSheetThemeData to return Clip.antiAliasWithSaveLayer instead of Clip.antiAlias.

antiAlias Vs antiAliasWithSaveLayer

Related Issues

#162

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

github-actions bot commented Mar 13, 2024

Visit the preview URL for this PR (updated for commit fee15cc):

(expires Thu, 21 Mar 2024 07:33:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 906758393beb0353b979d020649d6a1efc40fb5b

Co-authored-by: Taha Tesser <tessertaha@gmail.com>
@ulusoyca ulusoyca enabled auto-merge March 14, 2024 07:30
Copy link
Collaborator

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ulusoyca ulusoyca merged commit bf42933 into main Mar 14, 2024
4 checks passed
@ulusoyca ulusoyca deleted the change-default-top-bar-clip branch March 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants