Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add drag feature to Wolt Modal Bottom Sheet #206

Closed
wants to merge 2 commits into from

Conversation

AcarFurkan
Copy link
Collaborator

@AcarFurkan AcarFurkan commented May 12, 2024

Description

Scroll feature added to Wolt Modal Bottom sheet. enableDrag has been updated to enableCloseDrag. Now, when enableDrag is true, the position and size of the bottom sheet can change according to the user's wishes. enableDrag and enableCloseDrag can be used together or separately.
(I could not add these changes to the dynamic property page because there was a bug #205 in the operation of dynamic properties. That's why I assigned enableDrag to true in the home example so that you can test it.)

enableDrag=true && enableCloseDrag=false enableDrag=true && enableCloseDrag=true
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-12.at.18.24.30.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-12.at.18.24.05.mp4
enableDrag=false && enableCloseDrag=true enableDrag=false && enableCloseDrag=false
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-12.at.18.23.15.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-12.at.18.25.15.mp4

Related Issues

fix #171

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

github-actions bot commented May 12, 2024

Visit the preview URL for this PR (updated for commit 9ab1aac):

(expires Sun, 19 May 2024 15:37:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 906758393beb0353b979d020649d6a1efc40fb5b

@ulusoyca
Copy link
Collaborator

ulusoyca commented Jul 2, 2024

Let's revisit this one later. We have improved the modal drag a lot since this PR has been opened.

@ulusoyca ulusoyca closed this Jul 2, 2024
@josebejao
Copy link

josebejao commented Jul 3, 2024

Any plans to add this feature? It's very helpful @ulusoyca

@ulusoyca
Copy link
Collaborator

ulusoyca commented Jul 3, 2024

Yes, in the future it is possible. Current focus is allowing full customization for modals, and introduce Wolt defaults with 0.7.0. This can be investigated with persisten sheet epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to let user use drag up to expand to full screen height
3 participants