Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min supported Flutter version to 3.13.0 #219

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

ulusoyca
Copy link
Collaborator

@ulusoyca ulusoyca commented Jun 1, 2024

Description

According to last 4 stable version support rule, we are bumping the min supported Flutter SDK version to 3.13.0.

@ulusoyca ulusoyca requested a review from TahaTesser June 1, 2024 19:18
@ulusoyca ulusoyca force-pushed the bump-min-supported-version-to-3-13-0 branch from 0e3c19b to ac3e429 Compare June 1, 2024 19:50
@ulusoyca ulusoyca changed the title Bump min supported Flutter version to 3.13.9 Bump min supported Flutter version to 3.13.0 Jun 1, 2024
pubspec.yaml Show resolved Hide resolved
@TahaTesser
Copy link
Collaborator

@ulusoyca
Updated following deprecated APIs in 3.13.0 in 121bad9. Please take a look if it looks good. Also fixed checks,

Screenshot 2024-06-02 at 21 51 2 2

Screenshot 2024-06-02 at 21 48 45

Copy link
Collaborator

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed checks.yaml but deploy check is still failing for some reason, not sure why.

Otherwise, LGTM!

@ulusoyca
Copy link
Collaborator Author

ulusoyca commented Jun 4, 2024

@AcarFurkan Can you please fix the build_and_preview workflows accordingly and push the changes to this PR? Huge thanks!

@AcarFurkan
Copy link
Collaborator

@ulusoyca We are probably getting this error because the existing YAML is running in main. After we get the merge we can test it with a pr.

@ulusoyca ulusoyca merged commit 1ac2798 into main Jun 4, 2024
3 of 4 checks passed
@ulusoyca ulusoyca deleted the bump-min-supported-version-to-3-13-0 branch June 4, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants