-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FRNT- 456] Implement radio button #103
Conversation
|
||
export const InputPassword = styled(InputPasswordBase)` | ||
export const InputPassword = (styled(InputPasswordBase)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
зачем обертка?
@@ -16,7 +16,7 @@ export const Global = styled.div` | |||
|
|||
/* should be rewritten to formulas */ | |||
--woly-line-height: 24px; | |||
--woly-border-width: 1.5px; | |||
--woly-border-width: 2px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я правильно понимаю, что ты меняешь тут значение для radio button?
У primary не прописана ширина бордера и этот вариант берет ширину отсюда. надо бы прокинуть для primary ширину бордера.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А зачем менять ширину бордеров отдельно для primary?
Ширина бордеров должна быть везде одинакова, поэтому она не в variants
)} | ||
</State> | ||
</Playground> | ||
### Kinds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Добавить пробел сверху, чтоб не слипалось)
<State initial="no" change={(i) => !i}> | ||
{(value, change) => ( | ||
<> | ||
<RadioButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не работает смена установка в состояние checked с клавиатуры на первое нажатие enter
checked: boolean; | ||
onChange: React.EventHandler<React.SyntheticEvent>; | ||
text?: string; | ||
name: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
отсортируй плз
border-radius: var(--local-border-rounding); | ||
border: var(--woly-border-width) solid var(--local-border-color); | ||
|
||
margin-right: var(--local-gap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
погляди в макетах, у тебя расстояние между радиобаттоном и текстом меняется в зависимости от размера контейнера, а у тебя --local-gap констанста
@@ -16,7 +16,7 @@ export const Global = styled.div` | |||
|
|||
/* should be rewritten to formulas */ | |||
--woly-line-height: 24px; | |||
--woly-border-width: 1.5px; | |||
--woly-border-width: 2px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А зачем менять ширину бордеров отдельно для primary?
Ширина бордеров должна быть везде одинакова, поэтому она не в variants
keyboardEventHandle({ | ||
event, | ||
keyHandler, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А тут есть отписка от keyboard event?
No description provided.