-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
src/ui/atoms/list/usage.mdx
Outdated
@@ -1,13 +1,36 @@ | |||
--- | |||
name: list | |||
name: list-new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: list-new | |
name: list-container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Из этого названия генерируются импорты
1036c82
to
ed7f2b0
Compare
src/ui/atoms/list/index.tsx
Outdated
|
||
cursor: pointer; | ||
outline: none; | ||
interface ElementsProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
мб лучше назвать ListElementsProps? просто ElementsProps ничего не говорит
src/ui/atoms/list/index.tsx
Outdated
interface ElementsProps { | ||
iconLeft?: React.ReactNode; | ||
iconRight?: React.ReactNode; | ||
text: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а тут всегда будет только текст? здесь нельзя передавать компонент?
src/ui/atoms/list/index.tsx
Outdated
display: grid; | ||
grid-template-columns: 1fr; | ||
gap: var(--local-gap); | ||
background-color: var(--woly-canvas); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а что это за цвет такой? мб я не увидела, но вроде он не объявлен здесь и в палитре его нет
src/ui/atoms/list/index.tsx
Outdated
font-size: var(--woly-font-size); | ||
line-height: var(--woly-line-height); | ||
text-decoration: none; | ||
color: var(--woly-canvas-text-default); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
мб лучше было бы объявить в локальной переменной? этот цвет разве не будет меняться?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
он на 78 строчке в состоянии disabled становится другим
src/ui/atoms/list/index.tsx
Outdated
} | ||
} | ||
&:hover { | ||
background-color: var(--woly-canvas-disabled); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а изначально у контейнера вообще нет bg? мб он transparent?
src/ui/atoms/surface/index.tsx
Outdated
@@ -7,8 +7,8 @@ const map = (properties: Variant) => ({ | |||
|
|||
export const Surface = styled.div.attrs(map)` | |||
padding: var(--woly-padding, 0); | |||
background-color: var(--woly-canvas, #ffffff); | |||
border-color: var(--woly-border, #000000); | |||
background-color: var(--woly-canvas); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
такого цвета нет в палитре
ed7f2b0
to
2c49de3
Compare
Separate list container and list item