[FRNT-555] feat: implement avatar component #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchubarkin
force-pushed
the
FRNT-555/Avatar
branch
from
9221395
to
e1393ab
Compare
rchubarkin
changed the title
sergeysova
requested changes
Jun 18, 2021
src/ui/atoms/avatar/index.tsx
Outdated
| height: var(--local-size); | ||
| ` as StyledComponent<'div', Record<string, unknown>, Size>; | ||
|
|
||
| const imgStyles = css` |
src/ui/atoms/avatar/index.tsx
Outdated
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| width: var(--local-size); |
There was a problem hiding this comment.
можно задать 100%, чтобы аватар занимал весь объем контейнера и выбирать контейнер
src/ui/atoms/avatar/usage.mdx
Outdated
| `Avatar` shows user avatar | ||
|
|
||
| ### Example | ||
|
|
There was a problem hiding this comment.
мб сделаем пример, когда аватар вложенный компонент?
ainursharaev
requested changes
Jun 18, 2021
sergeysova
previously approved these changes
Jun 22, 2021
|
@rchubarkin порешаешь конфликты? |
rchubarkin
force-pushed
the
FRNT-555/Avatar
branch
3 times, most recently
from
7c8df88
to
851c70d
Compare
@sergeysova поправил конфликты |
rchubarkin
force-pushed
the
FRNT-555/Avatar
branch
from
851c70d
to
30c0160
Compare
src/ui/atoms/avatar/index.tsx
Outdated
|
|
||
| import { useImageLoad } from './use-image-load'; | ||
|
|
||
| const AvatarContainer = styled.div` |
There was a problem hiding this comment.
Если контейнер не экспортируется наружу, зачем создавать для него отдельный стайлед? Мб сразу стили прописать внутри аватара?
There was a problem hiding this comment.
имеешь ввиду через css и className?
There was a problem hiding this comment.
@sergeysova @purplecandle @tatinacher это проблема?
There was a problem hiding this comment.
думаю что возможно лишнее
|
@rchubarkin пофиксишь конфликты? |
rchubarkin
force-pushed
the
FRNT-555/Avatar
branch
from
30c0160
to
35d87b6
Compare
rchubarkin
force-pushed
the
FRNT-555/Avatar
branch
from
35d87b6
to
f1a4276
Compare
Irinaristova
approved these changes
Jun 23, 2021
sergeysova
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.