This repository has been archived by the owner on Jul 28, 2024. It is now read-only.
Fix random issues #190
Merged
Fix random issues #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 5, 2021 18:19
sergeysova
previously approved these changes
Aug 26, 2021
|
У тултипа текст черный на цветном фоне |
tatinacher
suggested changes
Aug 26, 2021
| @@ -54,102 +54,111 @@ export const Global = styled(WolyGlobalStyles)` | |||
|
|
|||
| [data-priority='default'] { | |||
| --woly-shape-default: hsla(var(--bw-500), 1); | |||
| --woly-shape-disabled: hsla(var(--bw-200), 1); | |||
| --woly-shape-disabled: hsla(var(--bw-500), 0.5); | |||
| @@ -98,7 +99,7 @@ export const TextArea = styled(TextAreaBase)` | |||
| resize: none; | |||
|
|
|||
| &::placeholder { | |||
There was a problem hiding this comment.
placeholder выглядит ярче, чем value, немного странно
There was a problem hiding this comment.
Тут палитры похоже не хватает
Поправил через opacity пока что
| @@ -26,15 +26,10 @@ const AccordionBase: React.FC<AccordionProps & Priority> = ({ | |||
| }, | |||
| [isContentVisible], | |||
| ); | |||
|
|
|||
| return ( | |||
There was a problem hiding this comment.
В первом примере бордер съехал вроде
There was a problem hiding this comment.
Снизу не бордер как оказалось, а Textarea которая багнулась из-за странного скрипта с установкой height через реф
Поправил, вроде не сломалось ничего
There was a problem hiding this comment.
чет у меня все так же с аккордеоном, погляди плз еще раз, точно поправилось?
sergeysova
requested review from
tatinacher
and removed request for
Irinaristova
tatinacher
suggested changes
Aug 30, 2021
| @@ -26,15 +26,10 @@ const AccordionBase: React.FC<AccordionProps & Priority> = ({ | |||
| }, | |||
| [isContentVisible], | |||
| ); | |||
|
|
|||
| return ( | |||
There was a problem hiding this comment.
чет у меня все так же с аккордеоном, погляди плз еще раз, точно поправилось?
tatinacher
approved these changes
Aug 30, 2021
sergeysova
approved these changes
Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Пофиксил всякие кривые штуки, будет круто если запустите и пробежитесь по всем компонентам