Remove rn-fetch-blob

[Serra19]

As @imranMnts said on #575, rn-fetch-blob is unmaintained since september 2020 joltup/rn-fetch-blob#666 so I'm making this PR to change that library and use react-native-blob-util as @imranMnts suggested.

react-native-blob-util supports windows, so I think the try/catch on index.js:25 is not needed anymore, and the library can be imported normally.

[RonRadtke]

@Serra19
I'm glad you want to migrate to my lib.
I recently published 0.13.8 with a few bugfixes. You might want to just bump the version to 0.13.8 directly :)

[ddikodroid]

have you tested it and not crashing?

[Serra19]

Yes, in fact, we're using this PR on our production app (android and ios) and it's working fine.

[lukutism]

Looking forward for this too. :)

[myklosbotond]

Shouldn't the readme also be updated to indicate the new package to install instead of rn-fetch-blob?

Also, any ideas why peerDependencies entry was removed in 119c292? IMO it would be best to add this library as a peer dependency if react-native-pdf cannot run without it. Especially since the try/catch was removed.

[csantos-r]

Shouldn't the readme also be updated to indicate the new package to install instead of rn-fetch-blob?

Also, any ideas why peerDependencies entry was removed in 119c292? IMO it would be best to add this library as a peer dependency if react-native-pdf cannot run without it. Especially since the try/catch was removed.

Did you solve this problem with react-native-pdf?

[keremoge]

Shouldn't the readme also be updated to indicate the new package to install instead of rn-fetch-blob?

Also, any ideas why peerDependencies entry was removed in 119c292? IMO it would be best to add this library as a peer dependency if react-native-pdf cannot run without it. Especially since the try/catch was removed.

Yes, readme file also should be updated @Serra19

[Serra19]

I've updated the readme file and the react-native-blob-util version for the example.

PD: Sorry for my late response! 🙏

[phillipkey]

There is a bit of urgency to this fix as rn-fetch-blob is using HostNameVerifier in such a way that the Google Play Store is blocking apps that are using it. Any news on when this fix will be released?

[ddikodroid]

There is a bit of urgency to this fix as rn-fetch-blob is using HostNameVerifier in such a way that the Google Play Store is blocking apps that are using it. Any news on when this fix will be released?

You can use this PR in package.json

[SimonIT]

@wonday Would you mind merging this PR?

[frenberg]

@wonday Would you mind merging this PR?

And while at it, bump major version and release on npm. I know its possible to specify git targets in package.json, but a new release is overdue.

[jaltin]

@wonday Would you mind merging this PR?

We are also keen that this PR gets accepted. Any chance it can be looked at @wonday?

[imknight]

There is a bit of urgency to this fix as rn-fetch-blob is using HostNameVerifier in such a way that the Google Play Store is blocking apps that are using it. Any news on when this fix will be released?

You can use this PR in package.json

mind to share how you did this? really need to get this working, i have something like this but still not working

    "react-native-blob-util": "^0.13.16",
    "react-native-pdf": "Serra19/react-native-pdf#remove-rn-fetch-blob",

[Drzaln]

@imknight try this command npm install wonday/react-native-pdf#578/head

[keremoge]

There is a bit of urgency to this fix as rn-fetch-blob is using HostNameVerifier in such a way that the Google Play Store is blocking apps that are using it. Any news on when this fix will be released?

You can use this PR in package.json

mind to share how you did this? really need to get this working, i have something like this but still not working

    "react-native-blob-util": "^0.13.16",
    "react-native-pdf": "Serra19/react-native-pdf#remove-rn-fetch-blob",

you can try this:

"react-native-pdf": "github:Serra19/react-native-pdf#remove-rn-fetch-blob",

[wonday]

Tanks all :-)