Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worksheet Input: Fails to find QR code from emailed jpeg #702

Closed
willsummers opened this issue Sep 21, 2017 · 7 comments
Closed

Worksheet Input: Fails to find QR code from emailed jpeg #702

willsummers opened this issue Sep 21, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@willsummers
Copy link

We can't use the local IP address import since our wired workstations and wireless devices are on different networks. We have had success emailing pictures to ourselves and then using the import worksheet command from there but we sometimes run into issues.

The image looks fine in Mac OS X 10.11.6 finder but then inputs upside down and doesn't find the QR code. When prompted to select the top-right corner I selected the top right corner of the scanned page (bottom left in the image since the page is upside down.) I hoped that the software would understand the orientation and turn the page around but it didn't work. I don't think it respects the image rotation that is done in Apple preview.

I solved the issue for myself by bringing all the worksheets into Photoshop, rotating them and then exporting them back out as PNG's but I would like to see it work in-app.

Here is a link to the file in question:
https://www.dropbox.com/s/fiu3xv1h00m8urz/IMG_1223.JPG.jpeg?dl=0

@setpixel
Copy link
Collaborator

setpixel commented Sep 21, 2017 via email

@setpixel setpixel added the bug label Sep 21, 2017
@setpixel setpixel added this to the RC1 milestone Sep 21, 2017
@setpixel
Copy link
Collaborator

@audionerd can we comment out the corner point sorting so it will allow him to rotate the image when tweaking the corners?

@audionerd
Copy link
Member

Could try that. Is the rest of the code smart enough to handle the rotation?

Probably the "right way to do it" would be to read the EXIF data containing orientation from the file: and rotate automatically, using e.g.: https://stackoverflow.com/a/32490603 or https://github.com/exif-js/exif-js

Related: #605

@setpixel
Copy link
Collaborator

I think its os specific perhaps. All of his images imported for me fine. So I don't know what the difference is.

@setpixel
Copy link
Collaborator

To test, you could also just take a picture and manually rotate it, or take a picture of a worksheet upside down.

@audionerd audionerd added this to Beta 13 in Features for RC1 Sep 23, 2017
@audionerd audionerd moved this from Beta 13 to IN PROGRESS in Features for RC1 Sep 27, 2017
audionerd added a commit that referenced this issue Oct 11, 2017
corner points entered by the user can be in any order
part of #702
@audionerd
Copy link
Member

audionerd commented Oct 11, 2017

While we don't yet have the ability to detect orientation, there will be a workaround for this issue in the next version of Storyboarder.

You can enter the QR code manually, then "Tweak Corner Points", and set the corners manually (accounting for rotation).

@audionerd audionerd moved this from IN PROGRESS to DONE in Features for RC1 Oct 11, 2017
@setpixel
Copy link
Collaborator

This is up live now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants