Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where blank board was created when trying to import an image #846

Merged
merged 4 commits into from Oct 27, 2017
Merged

Fix bug where blank board was created when trying to import an image #846

merged 4 commits into from Oct 27, 2017

Conversation

audionerd
Copy link
Member

Image import had some bugs

  • If image couldn't be loaded, blank board was created anyway
  • If filename extension was 'jpeg', JPG was not loaded

This refactors the code to fix up a few cases and make the logic a bit more clear overall.

PSD import works, but currently requires a layer named reference to be present in the PSD, which is the only layer that will be imported.

@audionerd audionerd merged commit 93c4b7c into master Oct 27, 2017
@audionerd audionerd deleted the import-image-bug branch October 27, 2017 19:40
@audionerd audionerd added this to DONE in Features for RC1 Oct 27, 2017
@audionerd audionerd removed this from DONE in Features for RC1 Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@audionerd