Claim actions by oldest ID #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that if multiple actions are scheduled for the same time, they will be run in the order in which they were created/scheduled.
JPry
approved these changes
May 11, 2018
JPry
added
the
has feedback
|
@JPry thanks for adding a unit test! I had it on my todo list to add but didn't get to it. The test looks good to me, so I'll merge now. 👍 |
thenbrent
pushed a commit
to woocommerce/action-scheduler-custom-tables
that referenced
this pull request
Jun 28, 2018
So that if multiple actions are scheduled for the same time, they will be run in the order in which they were created/scheduled. Fixes #21. Counterpart to woocommerce/action-scheduler#139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order actions by ID when staking a claim so that if multiple actions are scheduled for the same exact time (to the second), they will be run in the order in which they were created/scheduled.
However, be sure to apply the order only after ordering actions being claimed by number of previous attempts (
menu_order) and scheduled date (post_date_gmt), to preserve backward compatibility.Instigated by this Slack conversation.