Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reschedule the feed file generation to 24h. #1942

Merged
merged 3 commits into from May 12, 2021
Merged

Conversation

budzanowski
Copy link
Collaborator

@budzanowski budzanowski commented May 11, 2021

Changes proposed in this Pull Request:

By increasing the feed file generation interval we reduce the load that is put on the sites.

Closes #1941 .

How to test the changes in this Pull Request:

  1. In wp-content/plugins/facebook-for-woocommerce/class-wc-facebookcommerce.php change the VERSION const to 2.5.0.
  2. Refresh the admin panel.
  3. Go to WooCommerce -> Status -> Scheduled Actions
  4. Look for wc_facebook_regenerate_feed, it should be scheduled to run once a day.
    image

Changelog entry

Fix - Change feed generation cadence to 24h.

@budzanowski budzanowski requested a review from a team May 11, 2021 13:19
@budzanowski budzanowski self-assigned this May 11, 2021
@haszari haszari added this to the 2.5.0 milestone May 12, 2021
Copy link
Contributor

@danielbitzer danielbitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected 👍

Copy link
Member

@rcstr rcstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@budzanowski budzanowski merged commit 13d1fc7 into master May 12, 2021
@budzanowski budzanowski deleted the fix/issue-1941 branch May 12, 2021 09:27
@galapogos01
Copy link

galapogos01 commented Jul 8, 2021

When the feed generation task fails, it appears to reschedule itself for the next hour. So even though the task says daily, it's running (and failing) ~hourly (due to #1871).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase feed generation interval.
5 participants