Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor bundle size changes for PRs #818

Closed
tomalec opened this issue Jun 24, 2021 · 0 comments · Fixed by #819
Closed

Monitor bundle size changes for PRs #818

tomalec opened this issue Jun 24, 2021 · 0 comments · Fixed by #819
Labels
type: enhancement The issue is a request for an enhancement.
Projects

Comments

@tomalec
Copy link
Member

tomalec commented Jun 24, 2021

Given we are in a more relaxed time, maybe we would like to improve also our automation and GH tooling?

In the past we were facing some constraints for plugin.zip size, still, we would like to deliver less than more JS to the end customer. Maybe we could use some automation, to monitor if something goes off or provides a traffic benefit for the end-users.

Currently, our main js bundle has 718KB gzipped, which is pretty big IMHO.

User story

As a developer publishing PR or reviewing one, I'd like to easily monitor how the change affects the final bundle size.

Technical

We could use something like
https://github.com/siddharthkp/bundlesize

Build status baner

or https://github.com/bundlewatch/bundlewatch
image

I guess it should work as well for js as any other file.

Additional comments

@jconroy are we fine with authorizing the app?

@tomalec tomalec added the type: enhancement The issue is a request for an enhancement. label Jun 24, 2021
tomalec added a commit that referenced this issue Jun 24, 2021
to monitor our progress in reducing bundle size.

Fixes #818.
@jconroy jconroy added this to In progress in Woogle Jun 29, 2021
Woogle automation moved this from In progress to Done Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant