Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ISO3166 package to 4.1 #1761

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Update ISO3166 package to 4.1 #1761

merged 1 commit into from
Nov 11, 2022

Conversation

mikkamp
Copy link
Contributor

@mikkamp mikkamp commented Nov 10, 2022

Changes proposed in this Pull Request:

This PR updates the ISO3166 package to version 4.1, which removes any deprecation notices for PHP 8.1. The usage of the package remains the same so we don't need to adjust our code.

Note
Even though we are removing some deprecation notices, WP itself might still give other Deprecated notices for the Requests library, which are unrelated and need to be resolved in WP and/or WPCLI.
Unit test are also not ready to be run for PHP 8.1 (see further details here)

Closes #1745

Detailed test instructions:

  1. Setup the plugin on a site with PHP 8.1
  2. Send a request GET request to https://domain.test/wp-json/wc/gla/mc/target_audience (note onboarding must be completed)
  3. Ensure we receive a response with a list of countries
  4. If you are logging DEPRECATED notices to debug.log then check there before and after applying this PR, for the deprecated return type of ISO3166::count() or ISO3166::getIterator.

Changelog entry

  • Update - ISO3166 package version 4.1

@mikkamp mikkamp requested a review from a team November 10, 2022 16:35
@mikkamp mikkamp self-assigned this Nov 10, 2022
Copy link
Contributor

@jorgemd24 jorgemd24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mikkamp, the deprecated warning related to league/iso3166 are fixed 👍

As you mentioned in the issue: #1758 (comment) the warnings related to rmccue/requests are still present

image

@mikkamp mikkamp merged commit b75164e into develop Nov 11, 2022
@mikkamp mikkamp deleted the update-iso3166-package branch November 11, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 deprecated codes
2 participants