Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WP CLI apache modules #2045

Closed
wants to merge 1 commit into from
Closed

Conversation

martynmjones
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #2044

Adds a wp-cli.yml file containing mod_rewrite so that a .htaccess file can be generated when the permalinks are updated during wp-env setup.

Detailed test instructions:

  1. Checkout fix/add-wp-cli-config-file
  2. With docker running
  3. npm i && npm run wp-env start
  4. Visit http://localhost:8889/shop and confirm that the page loads

Additional details:

See: https://developer.wordpress.org/cli/commands/rewrite/structure/

Changelog entry

Tweak - Add configuration file for wp-env

@martynmjones martynmjones self-assigned this Aug 4, 2023
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Aug 4, 2023
@martynmjones martynmjones requested a review from a team August 4, 2023 19:15
@martynmjones
Copy link
Contributor Author

Jumped the gun after using wp-env for compatibility testing but this has been addressed #2041 so closing this PR and issue.

@eason9487 eason9487 deleted the fix/add-wp-cli-config-file branch August 18, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 errors on the frontend when using wp-env
1 participant