Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove partner token section in the Connection Test page #2410

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

jorgemd24
Copy link
Contributor

Changes proposed in this Pull Request:

This PR adds a section to revoke the WPCOM token associated with the Google client.

image

Screenshots:

Detailed test instructions:

  1. Apply the WPCOM Diff D149792
  2. Go to the Connection Test Page
  3. Go to https://wordpress.com/me/security/connected-applications and check that you have your application connected there.
  4. Click Revoke WPCOM Partner Access
  5. Refresh https://wordpress.com/me/security/connected-applications and see that the connection is gone.
  6. If there are not tokens associated you will get the following error {"code":"wpcom_partner_token_not_associated","message":"No token found associated with the client ID and user.","data":null}

Additional details:

Changelog entry

@github-actions github-actions bot added changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement. labels May 23, 2024
@jorgemd24 jorgemd24 self-assigned this May 23, 2024
@jorgemd24 jorgemd24 marked this pull request as ready for review May 23, 2024 17:38
@jorgemd24 jorgemd24 requested a review from a team May 23, 2024 17:38
@jorgemd24 jorgemd24 changed the title Add remove parter token action Add remove parter token section in the Connection Test page May 23, 2024
@jorgemd24 jorgemd24 changed the title Add remove parter token section in the Connection Test page Add remove partner token section in the Connection Test page May 23, 2024
@puntope
Copy link
Contributor

puntope commented May 27, 2024

Looking good @jorgemd24 just please see my comment in th Diff D149792 regarding the endpoint structure

@jorgemd24
Copy link
Contributor Author

Thanks @puntope for the review, I have updated the endpoint. This is ready for another round.

Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @jorgemd24 LGTM ✅

Base automatically changed from add/test-remote-site-status to feature/google-api-project June 3, 2024 10:22
@jorgemd24 jorgemd24 merged commit 3f8a5b8 into feature/google-api-project Jun 3, 2024
10 checks passed
@jorgemd24 jorgemd24 deleted the add/remove-partner-token branch June 3, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants