-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CI_BRANCH_BASE
for bundlewatch
on push events
#869
Conversation
BRANCH_BASE
for bundlewatch
on push events,BRANCH_BASE
for bundlewatch
on push events,
BRANCH_BASE
for bundlewatch
on push events,CI_BRANCH_BASE
for bundlewatch
on push events
Putting some additional notes here after discussion with @tomalec . Bundlewatch uses
Push events can happen when we merge a pull request from a feature branch into Specifying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we can go ahead and try this out. 🚀
🎉
|
Changes proposed in this Pull Request:
Set
BRANCH_BASE
forbundlewatch
on push events,workaround bundlewatch/bundlewatch#423.
Previously if no base was given, it was using hardcoded
master
which does not exist in our repo.See https://app.travis-ci.com/github/woocommerce/google-listings-and-ads/jobs/522666112#L14735
Screenshots:
Detailed test instructions:
trunk
:|Changelog entry