Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove phpcs-diff workaround #42

Open
tomalec opened this issue Sep 1, 2022 · 0 comments
Open

Remove phpcs-diff workaround #42

tomalec opened this issue Sep 1, 2022 · 0 comments
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves technical debt of the project.

Comments

@tomalec
Copy link
Member

tomalec commented Sep 1, 2022 •
edited by eason9487
Loading

UserDeveloper story

As the github-actions/actions/phpcs-diff/action.yml developer, I want to maintain the least amount of code possible.

Is your feature request related to a problem?

We used to have a problem that was worked around by #27
that originates in exussum12/coverageChecker#72, and was already fixed at source.

How to reproduce the problem

Run phpcs-diff action when no changes are made.

Describe the solution you'd like

Remove no longer needed code, once the https://github.com/exussum12/coverageChecker >1.0.2 is released

Describe alternatives you've considered

Technical

Figma link

n/a

Acceptance criteria

Unknowns

Out of bounds/rabbit holes

Event tracking

n/a
@tomalec tomalec added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves technical debt of the project. labels Sep 1, 2022
@eason9487 eason9487 changed the title Remove phpcd-diff workaround Remove phpcs-diff workaround Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomalec