Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the JSON syntax error of running phpcd-diff action when no changes are made #27

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Fix the JSON syntax error of running phpcd-diff action when no changes are made #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9e9cef
Fix the JSON syntax error of running PHPCS diff check when no changes…
eason9487 Jul 8, 2022
7d69c1e
Add a code comment for the workaround of empty result in phpcs-diff a…
eason9487 Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/js/github-actions/actions/phpcs-diff/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,21 @@ runs:
# a workflow to a pull request, it uses the revision of a merge commit to run the workflow
# as well. Therefore, `git diff HEAD^...HEAD` includes all diffs of a PR.
run: |
vendor/bin/diffFilter --phpcsStrict <(git diff HEAD^...HEAD) <(vendor/bin/phpcs ./* -q --report=json) --report=phpcs 0 > /tmp/phpcs-diff.json
JSON_REPORT="/tmp/phpcs-diff.json"
vendor/bin/diffFilter --phpcsStrict <(git diff HEAD^...HEAD) <(vendor/bin/phpcs ./* -q --report=json) --report=phpcs 0 > "$JSON_REPORT"

# It's a workaround that prevents the empty result from being passed as a JSON file to annotate-phpcs-report.js
# Related issue: https://github.com/exussum12/coverageChecker/issues/72
if [ ! -s "$JSON_REPORT" ]; then
echo "No changes."
exit 0
fi

cd "${{ github.action_path }}"
node annotate-phpcs-report.js /tmp/phpcs-diff.json
node annotate-phpcs-report.js "$JSON_REPORT"
cd -

TOTAL_ERRORS=$(jq ".totals.errors" /tmp/phpcs-diff.json)
TOTAL_ERRORS=$(jq ".totals.errors" "$JSON_REPORT"
if [ "$TOTAL_ERRORS" != "0" ]; then
exit 1
fi