Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trunk->develop merge step from the release checklist of automerge-released-trunk action #69

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Jul 24, 2023

This is a follow-up for #64

Changes proposed in this Pull Request:

Remove trunk->develop merge from release checklist
This step will be automatically covered by woocommerce/grow/automerge-released-trunk

Screenshots:

Detailed test instructions:

  1. Review the steps in https://github.com/woocommerce/grow/compare/fix/checklist-pr-automerge?expand=1#diff-4d854c0b5c65e4ad587b12c84b307cd46b76fb57dc662edd107e75f190036177

Additional details:

Changelog entry

Tweak - Remove trunk->develop merge step from the release checklist

This step will be automatically covered by woocommerce/grow/automerge-released-trunk
@tomalec tomalec requested a review from a team July 24, 2023 15:24
@tomalec tomalec self-assigned this Jul 24, 2023
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Considering the PR title will be used as an entry of release note, it would be a bit cleaner if the title also indicates which action to be tweaked.

@tomalec tomalec changed the title Remove trunk->develop merge step from the release checklist Remove trunk->develop merge step from the release checklist of automerge-released-trunk action Jul 25, 2023
@tomalec tomalec merged commit 28f5554 into trunk Jul 25, 2023
2 checks passed
@tomalec tomalec deleted the fix/checklist-pr-automerge branch July 25, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants