Capitalized title of release PR #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomalec could you give me a green light on this one and I'll merge it? |
This was referenced Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
As discussed in woocommerce/pinterest-for-woocommerce#788 (review), this PR capitalizes the name of the release PR created by the
Prepare New Releaseworkflow.Detailed test instructions:
Add a workflow in another repo following the instructions from
packages/js/github-actions/actions/prepare-extension-release/README.md, replacingwoocommerce/grow/prepare-extension-release@actions-v1withwoocommerce/grow/prepare-extension-release@actions-v1.5.2-preas this PR is not yet released.Like https://github.com/tomalec/grow/blob/391113cd2a00bac2dc808674ecebdb30e8fd83da/.github/workflows/extension-release.yml
Run the created workflow.
Confirm that the title of the release is capitalized (e.g.,
Releaseinstead ofreleaseorHotfixinstead ofhotfix.Changelog entry