Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Storefront Credit in the footer for SEO. #2096

Merged
merged 1 commit into from May 11, 2023
Merged

Updates Storefront Credit in the footer for SEO. #2096

merged 1 commit into from May 11, 2023

Conversation

jeffikus
Copy link
Member

Adds nofollow rel attribute to footer credit links.

Fix details as per @kevinbates SEO request paqDfi-7bi-p2#comment-15767

This fix adds a nofollow value to the existing rel attribute, changing the output to be "noreferrer nofollow" instead of just "noreferrer"

Screenshots

Before:

Screenshot 2023-05-10 at 22 16 10

After:

Screenshot 2023-05-10 at 22 23 01

How to test the changes in this Pull Request:

  1. Install and activate Storefront.
  2. Navigate to the homepage and inspect the markup of the footer credits.
  3. The rel attribute should show the correct values of "noreferrer nofollow"

Changelog

Fix – Adds nofollow value to rel attribute in footer credit link.

@jeffikus
Updates Storefront Credit in the footer for SEO.
84d9fb8 
Adds nofollow rel attribute to footer credit links.
@jeffikus jeffikus requested a review from kevinbates May 11, 2023 02:33
danielwrobert
danielwrobert approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Confirmed that the nofollow attribute is now present in the footer credits. Thank you!

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label May 11, 2023
@danielwrobert danielwrobert merged commit ef1f202 into trunk May 11, 2023
5 of 7 checks passed
@danielwrobert danielwrobert deleted the update/credit-seo-fix branch May 11, 2023 17:30
@danielwrobert danielwrobert removed the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label May 11, 2023
@danielwrobert danielwrobert self-assigned this May 11, 2023
@danielwrobert danielwrobert added this to the 4.3.0 milestone May 11, 2023
@Aljullu Aljullu mentioned this pull request Jul 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwrobert danielwrobert danielwrobert approved these changes

@kevinbates kevinbates Awaiting requested review from kevinbates

Assignees

@danielwrobert danielwrobert

Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffikus @danielwrobert