Fix typescript type error in admin-e2e-tests package (#7765)

* Fix type error * Update changelog * Better type handlings
woocommerce · Oct 23, 2021 · 5c8cd29 · 5c8cd29
1 parent ae3b49f
commit 5c8cd29
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/admin-e2e-tests/CHANGELOG.md b/packages/admin-e2e-tests/CHANGELOG.md
@@ -3,6 +3,8 @@
 
 -   Make unchecking free features more robust. #7761
 
+-   Fix typescript type error in admin-e2e-tests package #7765
+
 # 0.1.2
 
 -   Add Customers to analytics pages tested #7573

diff --git a/packages/admin-e2e-tests/src/pages/BasePage.ts b/packages/admin-e2e-tests/src/pages/BasePage.ts
@@ -142,9 +142,11 @@ export abstract class BasePage {
 				timeout: 10000,
 			} );
 		} catch ( e ) {
-			throw new Error(
-				`Could not navigate to url: ${ fullUrl } with error: ${ e.message }`
-			);
+			if ( e instanceof Error ) {
+				throw new Error(
+					`Could not navigate to url: ${ fullUrl } with error: ${ e.message }`
+				);
+			}
 		}
 	}
 }