Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Layout: Change Sidebar to Drawer #113

Closed
timmyc opened this issue Jun 13, 2018 · 1 comment
Closed

Layout: Change Sidebar to Drawer #113

timmyc opened this issue Jun 13, 2018 · 1 comment
Assignees
Labels
focus: activity panel Issues about activity/task panels on the home screen. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@timmyc
Copy link
Contributor

timmyc commented Jun 13, 2018

The final direction for the <Sidebar /> area of the app is for it to now act as a drawer - akin to the masterbar notifications panel on WPCOM. The desired functionality can be seen and interacted with here - but a .gif is worth a thousand words:

sidebar-action

Naming
As part of this task, I was wondering if we should consider renaming the containing component from Sidebar to something more in-line with what we refer to this feature as. The few names that come to mind for me are:

  • Activity Panel ( seems singular )
  • Activity Drawer

But I'm totally open to any and all ideas. Sidebar sounds a bit too much like the wp-admin sidebar nav that is always shown, vs this drawer that is accessible on all Woo screens.

Changes
This task definitely has some tie-in to #90 so perhaps this could be done along-side that or after. But the big changes needed are:

  • The sidebar/drawer no longer shrinks the content in div#woocommerce-layout__primary it overlays it
  • The sidebar/drawer by default is not exposed
  • Again in conjunction with Timeline: Update Tabs #90, the tabs control the display of the drawer. The only way the drawer can be closed is to click on the open tab again

/cc @jameskoster for any further interaction details that I may have missed

@timmyc timmyc added type: task The issue is an internally driven task (e.g. from another A8c team). Has Designs Ready focus: activity panel Issues about activity/task panels on the home screen. labels Jun 13, 2018
@timmyc timmyc added this to Backlog in Isotope Jun 14, 2018
@jameskoster
Copy link
Member

FWIW we've been calling it the Activity Panel in our discussions :)

@justinshreve justinshreve self-assigned this Jun 25, 2018
@justinshreve justinshreve moved this from Backlog to In progress in Isotope Jun 27, 2018
Isotope automation moved this from In progress 💻 to Done Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: activity panel Issues about activity/task panels on the home screen. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

3 participants