Expand WP notices with header toggle #101
Conversation
There was a problem hiding this comment.
Works as described 👍 Given the WP notice system I think this is a good-enough solution, maybe we'll get something better from Gutenberg eventually.
I also tested with a dismissable notice that adds an AJAX request to persist the dismiss state, and that worked too 👍
| this.maybeAddDismissEvents(); | ||
| } | ||
|
|
||
| this.setState( Object.assign( {}, { noticesOpen: ! noticesOpen } ) ); |
There was a problem hiding this comment.
Why the Object.assign in setState?
|
@jameskoster @josemarques How is this? I know the button/toggle might change so we can consider that temporary and subject to change, but does this work for actually displaying them? |
|
It works! The original plan was to move the entire UI down to reveal the notices like this; That helps distinguish these notices as a separate thing. |
|
@jameskoster I tried that initially (it's the default location for them) and thought maybe it would be better to not have the header bar get moved. There is a few lines of JS to move them around so that part is easy to change. So, if you think that would be better to have them separate, I can leave them above the bar. Preview:
|
|
If we do that, we'll need to do some focus management to make sure screen reader/keyboard users are navigated back to the notices (kind of like how dropdowns work). Currently this PR works "by default" because they come up next in the tab order. |
justinshreve
force-pushed
the
update/wpnotices
branch
from
0f48ff0
to
3649846
Compare
|
Thanks for the note there. I'll make sure to handle that if we decide to put the notices there. Just rebased this against master + changed CSS class names. |
|
Good point. Spoke with @josemarques about this and we decided your original approach is probably best overall. |
See #77.
Per p6riRB-3bd-p2 #comment-3810, this is an attempt at putting WP notices, hidden by default, behind a toggle that will display when there are notices present.
See this for a preview: https://cloudup.com/cUScXAMJH-R
It does some DOM manipulation that doesn't feel great, but if we hope to show these in a nice way to the user, that seems necessary no matter what based on how WP notices work (just HTML dumped into wp-admin -- no array or structure). Considering this a try branch for now incase someone has another idea.
To Test: