Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Add Taxes REST controller override #1407

Merged
merged 1 commit into from Jan 30, 2019
Merged

Add Taxes REST controller override #1407

merged 1 commit into from Jan 30, 2019

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jan 29, 2019

This PR adds an override to make the taxes API work with v4, like all other endpoints.

Screenshots

image

Detailed test instructions:

  • Go to the Taxes report.
  • Try searching in the table input box and verify the autocompleter works.

@Aljullu Aljullu self-assigned this Jan 29, 2019
@Aljullu Aljullu requested a review from a team January 29, 2019 10:17
@Aljullu Aljullu mentioned this pull request Jan 29, 2019
Merged
justinshreve
justinshreve approved these changes Jan 29, 2019
View reviewed changes
Copy link
Collaborator

@justinshreve justinshreve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the autocompleter is working 👍.

@Aljullu Aljullu merged commit 36f7887 into master Jan 30, 2019
@Aljullu Aljullu added this to 🧛‍♂️Sprint 12 Done in Isotope via automation Jan 30, 2019
@Aljullu Aljullu deleted the fix/taxes-rest-api-calls branch January 30, 2019 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinshreve justinshreve justinshreve approved these changes

Assignees

@Aljullu Aljullu

Labels
focus: wc rest api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aljullu @justinshreve