Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Fix incorrect label async request paths #1447

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Feb 1, 2019

Fixes #1424 fixes #1425

Fixes the request paths for getting labels to prevent the 404 and also show persisted comparison labels on page reload.

Screenshots

screen shot 2019-02-01 at 5 40 38 pm

Detailed test instructions:

  1. Go to the products report.
  2. Select 2 product using the product comparison filter and click "Compare."
  3. Make sure no 404s are shown under network requests.
  4. Refresh the page.
  5. Make sure that the comparison tags persist after reloading.
  6. Make sure that coupons, customers, and product variation comparison filters continue to work as expected.

@joshuatf joshuatf added [Status] Needs Review focus: analytics Issues about Analytics/Reports focus: components Issues for woocommerce components labels Feb 1, 2019
@joshuatf joshuatf self-assigned this Feb 1, 2019
@joshuatf joshuatf requested a review from a team February 1, 2019 09:44
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixed both issues. Thanks for taking this @joshuatf!

@joshuatf joshuatf merged commit 330b03a into master Feb 4, 2019
@joshuatf joshuatf deleted the fix/filter-label-404 branch February 4, 2019 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: analytics Issues about Analytics/Reports focus: components Issues for woocommerce components
Projects
None yet
2 participants