Fix date range dropdown for RTL locales #1803
Conversation
left: 50% !important; | ||
position: absolute; | ||
top: auto !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! I tested it in Firefox and wrongly assumed it would work in other browsers too.
I made that CSS ruleset to be ignored by the RTL plugin, so it should work fine now in both browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is a browser issue, but I noted an oddity with the left/right centering of the tooltip error message.
Thanks for tackling this! It works in non RTL as well. My calendar isn't rendering either, could that be related?
Thanks for the review @psealock. Can you take another look now? 🙂
Right, that's the last remaining issue from #1776. I'm trying to figure out what's going on there. I guess some CSS is interfering with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes second issue from #1776.
Screenshots
Before:
After:
Detailed test instructions: