This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Wait until all chart data page requests are complete before rendering. #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffstieler
added
type: bug
jeffstieler
added this to In Progress PRs (for automation purposes)
in Isotope
via automation
rrennick
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
@jeffstieler This works great and fixes the issue identified in #2775 (comment) 
Isotope
automation
moved this from In Progress PRs (for automation purposes)
to Done Sprint 23 (August 13 - August 26)
Aug 14, 2019
psealock
moved this from Done Sprint 23 (August 13 - August 26)
to 🤖 Done Sprint 22 (July 29 - August 12)
in Isotope
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2775. Pairs with #2710 and #2776.
When fetching data for charts with more than 1 page (100 items) of data, there is a chance that the request for the last page finishes before an earlier page, causing that page to be omitted from the chart render. This results in a single line connecting points across a long time scale.
This PR seeks to enforce that all page requests have finished before rendering the chart.
Note: when you do reproduce the bug, switching chart modes (line/bar) restores the data.
Screenshots
Before:
After:
Detailed test instructions:
Changelog Note:
Fix: chart data fetch/render over long time periods