Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Header: Set z-index greater than popover #280

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Header: Set z-index greater than popover #280

merged 1 commit into from
Aug 8, 2018

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Aug 7, 2018

Fixes #252

I was unable to reproduce the other issue summarized in 252, so this fix is soley for the z-index problem of the popover and navigation header.

To Test

  • Open up the revenue report
  • Expand the date picker
  • Scroll down and verify the picker popover is shown behind the navigation header

@timmyc timmyc added type: bug The issue is a confirmed bug. [Status] Needs Review labels Aug 7, 2018
@timmyc timmyc requested a review from a team August 7, 2018 20:01
psealock
psealock approved these changes Aug 7, 2018
View reviewed changes
Copy link
Collaborator

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, Thanks!

@timmyc timmyc merged commit 05d8c17 into master Aug 8, 2018
@timmyc timmyc added this to ☎️Sprint 2 Done in Isotope via automation Aug 8, 2018
@timmyc timmyc deleted the fix/navbar-zindex branch August 8, 2018 00:12
@psealock psealock mentioned this pull request Aug 9, 2018
Closed
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@psealock psealock psealock approved these changes

Assignees
No one assigned
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatePicker: Viewport oddities
2 participants
@timmyc @psealock