This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Datepicker: resize dropdown on tab switch #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
added
the
status: blocked
psealock
force-pushed
the
fix/dropdown-resize
branch
from
72ac40e
to
26159e8
Compare
psealock
force-pushed
the
fix/dropdown-resize
branch
from
26159e8
to
16cfef7
Compare
psealock
added
status: in progress
and removed
status: blocked
|
should we wait till 3.9 drops to merge this? |
|
No need to wait, there is a check to see if |
timmyc
approved these changes
Sep 19, 2018
| refreshDropdown() { | ||
| setTimeout( () => { | ||
| const dropdown = this.dropdownRef.current; | ||
| dropdown.refresh && dropdown.refresh(); |
There was a problem hiding this comment.
Ah gotcha - makes sense now :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh the dropdown size when switching tabs so scrollable areas are can be accessed.
Test
/wp-admin/admin.php?page=wc-admin#/analytics/productsDepends on WordPress/gutenberg#8906 (merged)
Fixes #252