Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Check if extended_info is set for order report items #3315

Merged
merged 1 commit into from Nov 29, 2019
Merged

Conversation

joshuatf
Copy link
Contributor

Fixes #3314

Checks for existence of extended_info properties before setting the column values.

Screenshots

Screen Shot 2019-11-28 at 1 44 53 PM

Detailed test instructions:

  1. Make sure WP_DEBUG_LOG is enabled.
  2. Create some refunds.
  3. Export an order via the REST API (post to wp-json/wc-analytics/reports/orders/export?email=true)
  4. Make sure no warnings or errors exist.

@joshuatf joshuatf requested a review from a team November 28, 2019 06:06
@joshuatf joshuatf self-assigned this Nov 28, 2019
Copy link
Collaborator

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuatf Nice fix 🚢

@rrennick rrennick added this to In Progress PRs (for automation purposes) in Isotope via automation Nov 28, 2019
@joshuatf joshuatf merged commit d3a837f into master Nov 29, 2019
Isotope automation moved this from In Progress PRs (for automation purposes) to Done Sprint 28 ( Nov 12 - Dec 2 ) Nov 29, 2019
@joshuatf joshuatf deleted the fix/3314 branch November 29, 2019 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: wc rest api type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orders report exporter has errors when refunds exist
2 participants