This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Make $customer_id public again #8371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs changelog entry
and removed
needs changelog entry
labels
joelclimbsthings
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
Hey @moon0326 , tested your branch with Square in sandbox mode, and no critical error. I also went through the steps and the error was thrown as expected. Looks great! 
adrianduffell
pushed a commit
that referenced
this pull request
Feb 24, 2022
* Make $customer_id public -- see issue 8369. We have a backward compatibility issue
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 10, 2022
* Make $customer_id public -- see issue 8369. We have a backward compatibility issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8369
This PR makes
customer_idvariable public to keep the backward compatibility.Detailed test instructions:
Follow test instructions from #8369 and confirm the transaction works without an error.
no changelog