Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for system vs user-created private order notes #206

Closed
aforcier opened this issue May 9, 2018 · 2 comments
Closed

Add support for system vs user-created private order notes #206

aforcier opened this issue May 9, 2018 · 2 comments
Assignees
@aforcier
Labels
needs: api support v3 Waiting for an API change in v3 before it can move forward. type: enhancement A request for an enhancement.
Projects
MVLP Kanban Board
Milestone
Public beta - Spr...

Comments

@aforcier
Copy link
Contributor

aforcier commented May 9, 2018 •
edited

When the V3 Woo API is rolled out, notes returned from the /wc/v3/orders/$orderId/notes/ endpoint will have a new author field, which is either a username on the site, or "system". This will allow us to style system vs user-created notes differently in the list.

We'll also be able set added_by_user = true (default is false) when creating a new note, which will mark the created note as being site user-created rather than system-generated. added_by_user == false corresponds to author = "system" in the note returned from the server.

Relevant class in the V3 dev API: link

iOS counterpart: woocommerce/woocommerce-ios#55
@aforcier aforcier added type: enhancement A request for an enhancement. needs: api support v3 Waiting for an API change in v3 before it can move forward. labels May 9, 2018
@aforcier
Copy link
Contributor Author

aforcier commented May 9, 2018 •
edited

Also see: woocommerce/wc-api-dev#109, and wordpress-mobile/WordPress-FluxC-Android#798 (comment).

@aforcier aforcier mentioned this issue May 9, 2018
Closed
@aforcier aforcier self-assigned this Nov 20, 2018
@bummytime bummytime mentioned this issue Nov 22, 2018
Closed
5 tasks
@aforcier aforcier mentioned this issue Nov 26, 2018
Merged
@aforcier aforcier added the MVLP label Nov 26, 2018
@aforcier aforcier added this to MVLP backlog in MVLP Kanban Board via automation Nov 26, 2018
@aforcier aforcier added this to the Public beta - Sprint 6 milestone Nov 26, 2018
@aforcier aforcier moved this from MVLP backlog to In Progress in MVLP Kanban Board Nov 26, 2018
@aforcier
Copy link
Contributor Author

Done in #523.

MVLP Kanban Board automation moved this from In Progress to Done/Merged Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aforcier aforcier

Labels
needs: api support v3 Waiting for an API change in v3 before it can move forward. type: enhancement A request for an enhancement.
Projects
No open projects
MVLP Kanban Board
  
Shipped in 0.21
Milestone
Public beta - Sprint 6
Development

No branches or pull requests
1 participant
@aforcier